fix alter add incorrect partition properties

Author: Dino123-maker

fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/commands/info/PartitionDefinition.java

@@ -97,6 +97,8 @@ public void validate(Map<String, String> otherProperties) {
             }
 
             Map<String, String> mergedMap = Maps.newHashMap();
+            // validate should not change partitionDesc properties
+            Map<String, String> oldProperties = this.properties == null ? null : Maps.newHashMap(this.properties);
             // Should putAll `otherProperties` before `this.properties`,
             // because the priority of partition is higher than table
             if (otherProperties != null) {
@@ -141,6 +143,7 @@ public void validate(Map<String, String> otherProperties) {
                     }
                 }
             }
+            this.properties = oldProperties; // recover properties
         } catch (Exception e) {
             throw new AnalysisException(e.getMessage(), e.getCause());
         }

regression-test/suites/alter_p2/test_alter_table_property.groovy

@@ -89,5 +89,37 @@ suite ("test_alter_table_property") {
     assertTrue(createTableStr.contains("\"storage_medium\" = \"ssd\""))
 
     sql "DROP TABLE ${tableName}"
+
+    tableName = "test_alter_table_partition_property_table"
+    sql "DROP TABLE IF EXISTS ${tableName}"
+    sql """
+    CREATE TABLE IF NOT EXISTS ${tableName}
+    (
+        k1 DATETIME(3),
+        k2 INT,
+        V1 VARCHAR(2048) REPLACE
+    )
+    PARTITION BY RANGE(k1)
+    (
+        PARTITION p1 VALUES LESS THAN ("2022-01-01 00:00:00.111"),
+        PARTITION p2 VALUES LESS THAN ("2022-02-01 00:00:00.111")
+    )
+    DISTRIBUTED BY HASH(k2) BUCKETS 2
+    PROPERTIES (
+        "replication_num" = "1",
+        "mutable" = "true"
+    )
+    """
+
+    sql """ALTER TABLE ${tableName} ADD PARTITION p3 VALUES LESS THAN ("2022-03-01 00:00:00.111") ("mutable" = "false")"""
+
+    def partitions = sql """SHOW PARTITIONS FROM ${tableName} where PartitionName = "p3" """
+    logger.info("partitions: $partitions")
+    def lastPartition = partitions[-1]
+    logger.info("lastPartition: $lastPartition")
+    def isMutable = lastPartition[-5]
+
+    logger.info("p3 IsMutable: ${isMutable}")
+    assertEquals('false', isMutable)
 }