Commit 1f6d752
authored
[fix](storage-engine) _clean_unused_rowset_metas should skip rowsets in _unused_rowsets map (#59390)
### What problem does this PR solve?
`_clean_unused_rowset_metas` could incorrectly remove rowset metas (and
its delete_bitmap) that are still tracked in the `_unused_rowsets` map,
which holds rowsets pending deletion.
The fix adds a check to skip these rowsets during cleanup, preventing
premature removal of `_unused_rowsets`. Otherwise, if query a mow table
with rowsets in `_unused_rowsets` map, and `_clean_unused_rowset_metas`
delete delete_bitmap of these rowset, will get duplicated keys.
### Release note
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [ ] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg:
apache/doris-website#1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR
should merge into -->1 parent e3e0590 commit 1f6d752
2 files changed
+6
-3
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
957 | 957 | | |
958 | 958 | | |
959 | 959 | | |
960 | | - | |
| 960 | + | |
| 961 | + | |
961 | 962 | | |
962 | 963 | | |
963 | 964 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
920 | 920 | | |
921 | 921 | | |
922 | 922 | | |
923 | | - | |
924 | | - | |
| 923 | + | |
| 924 | + | |
| 925 | + | |
| 926 | + | |
925 | 927 | | |
926 | 928 | | |
927 | 929 | | |
| |||
0 commit comments