Skip to content

Commit 25336e3

Browse files
committed
remove release_undone_filters
1 parent 4d6558e commit 25336e3

File tree

3 files changed

+0
-29
lines changed

3 files changed

+0
-29
lines changed

be/src/runtime/query_context.cpp

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -231,9 +231,6 @@ QueryContext::~QueryContext() {
231231
_runtime_predicates.clear();
232232
file_scan_range_params_map.clear();
233233
obj_pool.clear();
234-
if (_merge_controller_handler) {
235-
_merge_controller_handler->release_undone_filters(this);
236-
}
237234
_merge_controller_handler.reset();
238235

239236
DorisMetrics::instance()->query_ctx_cnt->increment(-1);

be/src/runtime_filter/runtime_filter_mgr.cpp

Lines changed: 0 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -433,30 +433,6 @@ Status RuntimeFilterMergeControllerEntity::_send_rf_to_target(GlobalMergeContext
433433
return st;
434434
}
435435

436-
void RuntimeFilterMergeControllerEntity::release_undone_filters(QueryContext* query_ctx) {
437-
std::unique_lock<std::shared_mutex> guard(_filter_map_mutex);
438-
for (auto& [filter_id, ctx] : _filter_map) {
439-
if (!ctx.done && !ctx.targetv2_info.empty()) {
440-
{
441-
std::lock_guard<std::mutex> l(ctx.mtx);
442-
ctx.merger->set_wrapper_state_and_ready_to_apply(
443-
RuntimeFilterWrapper::State::DISABLED,
444-
"rf coordinator's query context released before runtime filter is ready to "
445-
"apply");
446-
}
447-
auto st = _send_rf_to_target(ctx, std::weak_ptr<QueryContext> {}, 0,
448-
UniqueId(query_ctx->query_id()).to_proto(),
449-
query_ctx->execution_timeout());
450-
if (!st.ok()) {
451-
LOG(WARNING)
452-
<< "Failed to send runtime filter to target before query done. filter_id:"
453-
<< filter_id << " " << ctx.merger->debug_string() << " reason:" << st;
454-
}
455-
}
456-
}
457-
_filter_map.clear();
458-
}
459-
460436
std::string RuntimeFilterMergeControllerEntity::debug_string() {
461437
std::string result = "RuntimeFilterMergeControllerEntity Info:\n";
462438
std::shared_lock<std::shared_mutex> guard(_filter_map_mutex);

be/src/runtime_filter/runtime_filter_mgr.h

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -150,8 +150,6 @@ class RuntimeFilterMergeControllerEntity {
150150

151151
std::string debug_string();
152152

153-
void release_undone_filters(QueryContext* query_ctx);
154-
155153
bool empty() {
156154
std::shared_lock<std::shared_mutex> read_lock(_filter_map_mutex);
157155
return _filter_map.empty();

0 commit comments

Comments
 (0)