Skip to content

Commit 25be601

Browse files
committed
Adjust hive dirty tbrq case to assert non-crash query success
1 parent 7503ea4 commit 25be601

File tree

2 files changed

+9
-6
lines changed

2 files changed

+9
-6
lines changed

regression-test/data/external_table_p0/hive/ddl/test_hive_ddl_text_format.out

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,9 @@ qhs 2023-07-1e7d713b2e4b8515a 25 edbeba
3333
qhs D99 3 D
3434
qhs hnzqzj-20230718100635-05 24 hnzqzj
3535

36+
-- !dirty_typed_count --
37+
4
38+
3639
-- !dirty_after_fail --
3740
4
3841

@@ -70,5 +73,8 @@ qhs 2023-07-1e7d713b2e4b8515a 25 edbeba
7073
qhs D99 3 D
7174
qhs hnzqzj-20230718100635-05 24 hnzqzj
7275

76+
-- !dirty_typed_count --
77+
4
78+
7379
-- !dirty_after_fail --
7480
4

regression-test/suites/external_table_p0/hive/ddl/test_hive_ddl_text_format.groovy

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -165,12 +165,9 @@ suite("test_hive_ddl_text_format", "p0,external,hive,external_docker,external_do
165165
'location'='${dirty_tbl_loc}'
166166
);
167167
"""
168-
// Dirty tbrq data should not cause core, expect parse failure.
169-
test {
170-
sql """ select * from ${dirty_typed_tbl} """
171-
exception "parse date fail"
172-
}
173-
// verify process is still healthy after parse failure (no core dump)
168+
// Dirty tbrq data should not cause core. Query must return normally.
169+
order_qt_dirty_typed_count """ select count(*) from ${dirty_typed_tbl} """
170+
// verify process is still healthy after dirty-data query (no core dump)
174171
order_qt_dirty_after_fail """ select count(*) from ${dirty_raw_tbl} """
175172

176173
String serde = "'org.apache.hadoop.hive.serde2.lazy.LazySimpleSerDe'"

0 commit comments

Comments
 (0)