reuse format logic

Author: linrrzqqq

be/src/vec/runtime/time_value.h

@@ -162,222 +162,9 @@ class TimeValue {
             time = -time;
         }
 
-        int32_t hour = TimeValue::hour(time);
-        int32_t minute = TimeValue::minute(time);
-        int32_t second = TimeValue::second(time);
-        int32_t microsecond = TimeValue::microsecond(time);
-
-        char* const begin = to;
-        char buf[64];
-        char* pos = nullptr;
-        char* cursor = buf;
-        const char* ptr = format;
-        const char* end = format + len;
-        char ch = '\0';
-
-        while (ptr < end) {
-            if (to - begin + SAFE_FORMAT_STRING_MARGIN > max_valid_length) [[unlikely]] {
-                return false;
-            }
-            if (*ptr != '%' || (ptr + 1) == end) {
-                *to++ = *ptr++;
-                continue;
-            }
-            ptr++;
-            switch (ch = *ptr++) {
-            case 'H':
-                // Hour (00..838 for TIME type, with at least 2 digits)
-                if (hour < 100) {
-                    to = write_two_digits_to_string(hour, to);
-                } else {
-                    pos = int_to_str(hour, cursor);
-                    to = append_with_prefix(cursor, static_cast<int>(pos - cursor), '0', 2, to);
-                }
-                break;
-            case 'h':
-            case 'I':
-                // Hour (01..12)
-                to = write_two_digits_to_string((hour % 24 + 11) % 12 + 1, to);
-                break;
-            case 'i':
-                // Minutes, numeric (00..59)
-                to = write_two_digits_to_string(minute, to);
-                break;
-            case 'k':
-                // Hour (0..23) without leading zero
-                pos = int_to_str(hour, cursor);
-                to = append_with_prefix(cursor, static_cast<int>(pos - cursor), '0', 1, to);
-                break;
-            case 'l':
-                // Hour (1..12) without leading zero
-                pos = int_to_str((hour % 24 + 11) % 12 + 1, cursor);
-                to = append_with_prefix(cursor, static_cast<int>(pos - cursor), '0', 1, to);
-                break;
-            case 's':
-            case 'S':
-                // Seconds (00..59)
-                to = write_two_digits_to_string(second, to);
-                break;
-            case 'f':
-                // Microseconds (000000..999999)
-                pos = int_to_str(microsecond, cursor);
-                to = append_with_prefix(cursor, static_cast<int>(pos - cursor), '0', 6, to);
-                break;
-            case 'p': {
-                // AM or PM
-                if (hour % 24 >= 12) {
-                    to = append_string("PM", to);
-                } else {
-                    to = append_string("AM", to);
-                }
-                break;
-            }
-            case 'r': {
-                // Time, 12-hour (hh:mm:ss followed by AM or PM)
-                int32_t hour_12 = (hour + 11) % 12 + 1;
-                *to++ = (char)('0' + (hour_12 / 10));
-                *to++ = (char)('0' + (hour_12 % 10));
-                *to++ = ':';
-                *to++ = (char)('0' + (minute / 10));
-                *to++ = (char)('0' + (minute % 10));
-                *to++ = ':';
-                *to++ = (char)('0' + (second / 10));
-                *to++ = (char)('0' + (second % 10));
-                if (hour % 24 >= 12) {
-                    to = append_string(" PM", to);
-                } else {
-                    to = append_string(" AM", to);
-                }
-                break;
-            }
-            case 'T': {
-                // Time, 24-hour (hh:mm:ss or hhh:mm:ss for TIME type)
-                if (hour < 100) {
-                    *to++ = (char)('0' + (hour / 10));
-                    *to++ = (char)('0' + (hour % 10));
-                } else {
-                    // For hours >= 100, convert to string with at least 2 digits
-                    pos = int_to_str(hour, cursor);
-                    to = append_with_prefix(cursor, static_cast<int>(pos - cursor), '0', 2, to);
-                }
-                *to++ = ':';
-                *to++ = (char)('0' + (minute / 10));
-                *to++ = (char)('0' + (minute % 10));
-                *to++ = ':';
-                *to++ = (char)('0' + (second / 10));
-                *to++ = (char)('0' + (second % 10));
-                break;
-            }
-            case '%':
-                *to++ = '%';
-                break;
-            case 'Y':
-                // Year, 4 digits - 4 zeros
-                to = append_string("0000", to);
-                break;
-            case 'y':
-            case 'm':
-            case 'd':
-                // Year (2 digits), Month, Day - insert 2 zeros
-                to = write_two_digits_to_string(0, to);
-                break;
-            case 'c':
-            case 'e':
-                // Month (0..12) or Day without leading zero - insert 1 zero
-                to = append_string("0", to);
-                break;
-            case 'M':
-            case 'W':
-            case 'j':
-            case 'D':
-            case 'U':
-            case 'u':
-            case 'V':
-            case 'v':
-            case 'x':
-            case 'X':
-            case 'w':
-                // These specifiers are not supported for TIME type
-                return false;
-            default:
-                *to++ = ch;
-                break;
-            }
-        }
-        *to++ = '\0';
-        return true;
-    }
-
-private:
-    static constexpr char digits100[201] =
-            "00010203040506070809"
-            "10111213141516171819"
-            "20212223242526272829"
-            "30313233343536373839"
-            "40414243444546474849"
-            "50515253545556575859"
-            "60616263646566676869"
-            "70717273747576777879"
-            "80818283848586878889"
-            "90919293949596979899";
-
-    static char* int_to_str(uint64_t val, char* to) {
-        char buf[64];
-        char* ptr = buf;
-        // Use do/while for 0 value
-        do {
-            *ptr++ = '0' + (val % 10);
-            val /= 10;
-        } while (val);
-
-        while (ptr > buf) {
-            *to++ = *--ptr;
-        }
-        return to;
-    }
-
-    static char* append_string(const char* from, char* to) {
-        while (*from) {
-            *to++ = *from++;
-        }
-        return to;
-    }
-
-    static char* append_with_prefix(const char* str, int str_len, char prefix, int target_len,
-                                    char* to) {
-        // full_len is the lower bound. if less, use prefix to pad. if greater, accept all.
-        int diff = target_len - str_len;
-        // use prefix to pad
-        while (diff-- > 0) {
-            *to++ = prefix;
-        }
-
-        memcpy(to, str, str_len);
-        return to + str_len;
-    }
-
-    static char* write_two_digits_to_string(int number, char* dst) {
-        memcpy(dst, &digits100[number * 2], 2);
-        return dst + 2;
-    }
-
-    static bool is_date_related_specifier(char spec) {
-        switch (spec) {
-        case 'Y':
-        case 'y':
-        case 'M':
-        case 'm':
-        case 'b':
-        case 'c':
-        case 'd':
-        case 'D':
-        case 'e':
-        case 'j':
-        case 'U':
-            return true;
-        default:
-            return false;
-        }
+        return DateV2Value<DateTimeV2ValueType>::to_format_string_without_check(
+                format, len, to, max_valid_length, 0, 0, 0, TimeValue::hour(time),
+                TimeValue::minute(time), TimeValue::second(time), TimeValue::microsecond(time));
     }
 };
 } // namespace doris