fix review

Author: deardeng

fe/fe-common/src/main/java/org/apache/doris/common/Config.java

@@ -3447,6 +3447,10 @@ public static int metaServiceRpcRetryTimes() {
             + "is the active tablet priority scheduling strategy enabled?  (Default: Enabled)"})
     public static boolean enable_cloud_active_tablet_priority_scheduling = true;
 
+    @ConfField(masterOnly = true, description = {"滑动窗口访问统计的时间窗口大小（秒），默认3600秒（1小时）",
+            "Time window size in seconds for sliding window access statistics, default 3600 seconds (1 hour)"})
+    public static long sliding_window_time_window_second = 3600L;
+
     @ConfField(mutable = true, masterOnly = false)
     public static String security_checker_class_name = "";
 

fe/fe-core/src/main/java/org/apache/doris/catalog/Tablet.java

@@ -24,7 +24,7 @@
 import org.apache.doris.common.FeConstants;
 import org.apache.doris.common.Pair;
 import org.apache.doris.common.UserException;
-import org.apache.doris.common.util.SlidingWindowAccessStats;
+import org.apache.doris.common.util.SlidingWindowAccessStatsFactory;
 import org.apache.doris.resource.Tag;
 import org.apache.doris.system.Backend;
 import org.apache.doris.system.SystemInfoService;
@@ -248,8 +248,7 @@ protected Multimap<Long, Long> getNormalReplicaBackendPathMapImpl(String beEndpo
     // for load plan.
     public Multimap<Long, Long> getNormalReplicaBackendPathMap() throws UserException {
         return getNormalReplicaBackendPathMapImpl(null, (rep, be) -> {
-            // Use async version to avoid blocking getBackendIdImpl which is called frequently
-            SlidingWindowAccessStats.getInstance().recordAccessAsync(getId());
+            SlidingWindowAccessStatsFactory.recordTablet(getId());
             return rep.getBackendId();
         });
     }
@@ -265,8 +264,7 @@ public List<Replica> getQueryableReplicas(long visibleVersion, Map<Long, Set<Lon
         List<Replica> deadPathReplica = Lists.newArrayListWithCapacity(replicaNum);
         List<Replica> mayMissingVersionReplica = Lists.newArrayListWithCapacity(replicaNum);
         List<Replica> notCatchupReplica = Lists.newArrayListWithCapacity(replicaNum);
-        // Use async version to avoid blocking getBackendIdImpl which is called frequently
-        SlidingWindowAccessStats.getInstance().recordAccessAsync(getId());
+        SlidingWindowAccessStatsFactory.recordTablet(getId());
 
         for (Replica replica : replicas) {
             if (replica.isBad()) {

fe/fe-core/src/main/java/org/apache/doris/cloud/catalog/CloudReplica.java

@@ -29,7 +29,6 @@
 import org.apache.doris.common.DdlException;
 import org.apache.doris.common.Pair;
 import org.apache.doris.common.util.DebugPointUtil;
-import org.apache.doris.common.util.SlidingWindowAccessStats;
 import org.apache.doris.qe.ConnectContext;
 import org.apache.doris.system.Backend;
 
@@ -303,8 +302,6 @@ private long getBackendIdImpl(String clusterId) throws ComputeGroupException {
         if (Strings.isNullOrEmpty(clusterId)) {
             return -1L;
         }
-        // Use async version to avoid blocking getBackendIdImpl which is called frequently
-        SlidingWindowAccessStats.getInstance().recordAccessAsync(getId());
 
         if (isColocated()) {
             return getColocatedBeId(clusterId);

fe/fe-core/src/main/java/org/apache/doris/cloud/catalog/CloudTablet.java

@@ -22,7 +22,7 @@
 import org.apache.doris.catalog.Tablet;
 import org.apache.doris.common.InternalErrorCode;
 import org.apache.doris.common.UserException;
-import org.apache.doris.common.util.SlidingWindowAccessStats;
+import org.apache.doris.common.util.SlidingWindowAccessStatsFactory;
 import org.apache.doris.system.SystemInfoService;
 
 import com.google.common.collect.Multimap;
@@ -61,17 +61,15 @@ private Multimap<Long, Long> backendPathMapReprocess(Multimap<Long, Long> pathMa
 
     @Override
     public Multimap<Long, Long> getNormalReplicaBackendPathMap() throws UserException {
-        // Use async version to avoid blocking getBackendIdImpl which is called frequently
-        SlidingWindowAccessStats.getInstance().recordAccessAsync(getId());
+        SlidingWindowAccessStatsFactory.recordTablet(getId());
         Multimap<Long, Long> pathMap = super.getNormalReplicaBackendPathMap();
         return backendPathMapReprocess(pathMap);
     }
 
     public Multimap<Long, Long> getNormalReplicaBackendPathMap(String beEndpoint) throws UserException {
         Multimap<Long, Long> pathMap = super.getNormalReplicaBackendPathMapImpl(beEndpoint,
                 (rep, be) -> {
-                    // Use async version to avoid blocking getBackendIdImpl which is called frequently
-                    SlidingWindowAccessStats.getInstance().recordAccessAsync(getId());
+                    SlidingWindowAccessStatsFactory.recordTablet(getId());
                     return ((CloudReplica) rep).getBackendId(be);
                 });
         return backendPathMapReprocess(pathMap);

fe/fe-core/src/main/java/org/apache/doris/cloud/catalog/CloudTabletRebalancer.java

@@ -39,6 +39,7 @@
 import org.apache.doris.common.util.DebugPointUtil;
 import org.apache.doris.common.util.MasterDaemon;
 import org.apache.doris.common.util.SlidingWindowAccessStats;
+import org.apache.doris.common.util.SlidingWindowAccessStatsFactory;
 import org.apache.doris.metric.MetricRepo;
 import org.apache.doris.rpc.RpcException;
 import org.apache.doris.service.FrontendOptions;
@@ -1709,7 +1710,7 @@ private Set<Long> getActiveTabletIds() {
         try {
             // get topN active tablets
             List<SlidingWindowAccessStats.AccessStatsResult> active =
-                    SlidingWindowAccessStats.getInstance().getTopNActiveTablets(10000);
+                    SlidingWindowAccessStatsFactory.getTabletAccessStats().getTopNActive(10000);
             if (active == null || active.isEmpty()) {
                 return Collections.emptySet();
             }

fe/fe-core/src/main/java/org/apache/doris/common/proc/ReplicasProcNode.java

@@ -28,6 +28,7 @@
 import org.apache.doris.common.Config;
 import org.apache.doris.common.util.NetUtils;
 import org.apache.doris.common.util.SlidingWindowAccessStats;
+import org.apache.doris.common.util.SlidingWindowAccessStatsFactory;
 import org.apache.doris.common.util.TimeUtils;
 import org.apache.doris.statistics.query.QueryStatsUtil;
 import org.apache.doris.system.Backend;
@@ -92,8 +93,8 @@ public ProcResult fetchResult() throws AnalysisException {
         }
 
         for (Replica replica : replicas) {
-            SlidingWindowAccessStats.AccessStatsResult asr = SlidingWindowAccessStats.getInstance()
-                    .getTabletAccessInfo(tabletId);
+            SlidingWindowAccessStats.AccessStatsResult asr = SlidingWindowAccessStatsFactory.getTabletAccessStats()
+                    .getAccessInfo(tabletId);
             long accessCount1H = 0;
             long lastAccessTime = 0;
             if (asr != null) {

fe/fe-core/src/main/java/org/apache/doris/common/proc/TabletsProcDir.java

@@ -30,6 +30,7 @@
 import org.apache.doris.common.util.ListComparator;
 import org.apache.doris.common.util.NetUtils;
 import org.apache.doris.common.util.SlidingWindowAccessStats;
+import org.apache.doris.common.util.SlidingWindowAccessStatsFactory;
 import org.apache.doris.common.util.TimeUtils;
 import org.apache.doris.statistics.query.QueryStatsUtil;
 import org.apache.doris.system.Backend;
@@ -144,8 +145,8 @@ public List<List<Comparable>> fetchComparableResult(long version, long backendId
 
                     tabletInfos.add(tabletInfo);
                 } else {
-                    SlidingWindowAccessStats.AccessStatsResult asr = SlidingWindowAccessStats.getInstance()
-                            .getTabletAccessInfo(tabletId);
+                    SlidingWindowAccessStats.AccessStatsResult asr = SlidingWindowAccessStatsFactory
+                            .getTabletAccessStats().getAccessInfo(tabletId);
                     long accessCount1H = 0;
                     long lastAccessTime = 0;
                     if (asr != null) {

fe/fe-core/src/main/java/org/apache/doris/common/util/AccessStatsIdType.java

@@ -0,0 +1,26 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package org.apache.doris.common.util;
+
+/**
+ * ID type for access statistics
+ */
+public enum AccessStatsIdType {
+    TABLET,      // Tablet ID statistics
+    // Add more types as needed
+}