debug

Author: bobhan1

be/src/olap/compaction.cpp

@@ -91,12 +91,18 @@ namespace {
 #include "common/compile_check_begin.h"
 
 bool is_rowset_tidy(std::string& pre_max_key, bool& pre_rs_key_bounds_truncated,
-                    const RowsetSharedPtr& rhs) {
+                    const RowsetSharedPtr& rhs, int64_t tablet_id) {
     size_t min_tidy_size = config::ordered_data_compaction_min_segment_size;
     if (rhs->num_segments() == 0) {
+        LOG(INFO) << "rowset is tidy for tablet=" << tablet_id
+                  << ", rowset_id=" << rhs->rowset_id().to_string()
+                  << ", reason: num_segments is 0";
         return true;
     }
     if (rhs->is_segments_overlapping()) {
+        LOG(INFO) << "rowset is not tidy for tablet=" << tablet_id
+                  << ", rowset_id=" << rhs->rowset_id().to_string()
+                  << ", reason: segments are overlapping";
         return false;
     }
     // check segment size
@@ -106,21 +112,33 @@ bool is_rowset_tidy(std::string& pre_max_key, bool& pre_rs_key_bounds_truncated,
     for (auto segment_size : segments_size) {
         // is segment is too small, need to do compaction
         if (segment_size < min_tidy_size) {
+            LOG(INFO) << "rowset is not tidy for tablet=" << tablet_id
+                      << ", rowset_id=" << rhs->rowset_id().to_string() << ", reason: segment size "
+                      << segment_size << " is less than min_tidy_size " << min_tidy_size;
             return false;
         }
     }
     std::string min_key;
     auto ret = rhs->first_key(&min_key);
     if (!ret) {
+        LOG(INFO) << "rowset is not tidy for tablet=" << tablet_id
+                  << ", rowset_id=" << rhs->rowset_id().to_string()
+                  << ", reason: failed to get first_key";
         return false;
     }
     bool cur_rs_key_bounds_truncated {rhs->is_segments_key_bounds_truncated()};
     if (!Slice::lhs_is_strictly_less_than_rhs(Slice {pre_max_key}, pre_rs_key_bounds_truncated,
                                               Slice {min_key}, cur_rs_key_bounds_truncated)) {
+        LOG(INFO)
+                << "rowset is not tidy for tablet=" << tablet_id
+                << ", rowset_id=" << rhs->rowset_id().to_string()
+                << ", reason: key range overlaps with previous rowset (pre_max_key >= cur_min_key)";
         return false;
     }
     CHECK(rhs->last_key(&pre_max_key));
     pre_rs_key_bounds_truncated = cur_rs_key_bounds_truncated;
+    LOG(INFO) << "rowset is tidy for tablet=" << tablet_id
+              << ", rowset_id=" << rhs->rowset_id().to_string();
     return true;
 }
 
@@ -428,20 +446,28 @@ Status CompactionMixin::build_basic_info(bool is_ordered_compaction) {
 
 bool CompactionMixin::handle_ordered_data_compaction() {
     if (!config::enable_ordered_data_compaction) {
+        LOG(INFO) << "skip ordered data compaction for tablet=" << _tablet->tablet_id()
+                  << ", reason: enable_ordered_data_compaction config is disabled";
         return false;
     }
     if (compaction_type() == ReaderType::READER_COLD_DATA_COMPACTION ||
         compaction_type() == ReaderType::READER_FULL_COMPACTION) {
         // The remote file system and full compaction does not support to link files.
+        LOG(INFO) << "skip ordered data compaction for tablet=" << _tablet->tablet_id()
+                  << ", reason: compaction type is COLD_DATA or FULL_COMPACTION";
         return false;
     }
     if (_tablet->keys_type() == KeysType::UNIQUE_KEYS &&
         _tablet->enable_unique_key_merge_on_write()) {
+        LOG(INFO) << "skip ordered data compaction for tablet=" << _tablet->tablet_id()
+                  << ", reason: unique keys with merge-on-write enabled";
         return false;
     }
 
     if (_tablet->tablet_meta()->tablet_schema()->skip_write_index_on_load()) {
         // Expected to create index through normal compaction
+        LOG(INFO) << "skip ordered data compaction for tablet=" << _tablet->tablet_id()
+                  << ", reason: skip_write_index_on_load is enabled";
         return false;
     }
 
@@ -452,6 +478,9 @@ bool CompactionMixin::handle_ordered_data_compaction() {
          compaction_type() == ReaderType::READER_CUMULATIVE_COMPACTION)) {
         for (auto& rowset : _input_rowsets) {
             if (rowset->rowset_meta()->has_delete_predicate()) {
+                LOG(INFO) << "skip ordered data compaction for tablet=" << _tablet->tablet_id()
+                          << ", reason: rowset has delete predicate, rowset_id="
+                          << rowset->rowset_id().to_string();
                 return false;
             }
         }
@@ -463,8 +492,12 @@ bool CompactionMixin::handle_ordered_data_compaction() {
     std::string pre_max_key;
     bool pre_rs_key_bounds_truncated {false};
     for (auto i = 0; i < input_size; ++i) {
-        if (!is_rowset_tidy(pre_max_key, pre_rs_key_bounds_truncated, _input_rowsets[i])) {
+        if (!is_rowset_tidy(pre_max_key, pre_rs_key_bounds_truncated, _input_rowsets[i],
+                            _tablet->tablet_id())) {
             if (i <= input_size / 2) {
+                LOG(INFO) << "skip ordered data compaction for tablet=" << _tablet->tablet_id()
+                          << ", reason: rowsets are not tidy, untidy rowset at position " << i
+                          << " out of " << input_size << " (less than half)";
                 return false;
             } else {
                 _input_rowsets.resize(i);
@@ -478,6 +511,11 @@ bool CompactionMixin::handle_ordered_data_compaction() {
     if (!st.ok()) {
         LOG(WARNING) << "failed to compact ordered rowsets: " << st;
         _pending_rs_guard.drop();
+        LOG(INFO) << "skip ordered data compaction for tablet=" << _tablet->tablet_id()
+                  << ", reason: do_compact_ordered_rowsets failed with status: " << st;
+    } else {
+        LOG(INFO) << "handle ordered data compaction success for tablet=" << _tablet->tablet_id()
+                  << ", input_rowsets=" << _input_rowsets.size();
     }
 
     return st.ok();

regression-test/suites/fault_injection_p0/test_ordered_compaction_num_seg_rows.groovy

@@ -23,9 +23,23 @@ suite("test_ordered_compaction_num_seg_rows","nonConcurrent") {
     }
 
     def custoBeConfig = [
-        ordered_data_compaction_min_segment_size : 1
+        ordered_data_compaction_min_segment_size : 1,
+        enable_ordered_data_compaction: true
     ]
     setBeConfigTemporary(custoBeConfig) {
+
+        String backend_id;
+        def backendId_to_backendIP = [:]
+        def backendId_to_backendHttpPort = [:]
+        getBackendIpHttpPort(backendId_to_backendIP, backendId_to_backendHttpPort);
+
+        backend_id = backendId_to_backendIP.keySet()[0]
+        def (code1, out1, err1) = show_be_config(backendId_to_backendIP.get(backend_id), backendId_to_backendHttpPort.get(backend_id))
+
+        logger.info("Show config: code=" + code1 + ", out=" + out1 + ", err=" + err1)
+        assert code1 == 0
+
+
         def tableName = "test_ordered_compaction_num_seg_rows"
         sql """ DROP TABLE IF EXISTS ${tableName} """
         sql """