Skip to content

Commit a5e55af

Browse files
dataroaringclaude
andcommitted
[refactor](read-uncommitted) Register uncommitted rowset in commit_rowset
Move registration into CloudDeltaWriter::commit_rowset() right after the meta service commit succeeds, which is the natural point where the rowset becomes committed-but-not-published. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
1 parent 99de6cb commit a5e55af

File tree

3 files changed

+3
-12
lines changed

3 files changed

+3
-12
lines changed

be/src/cloud/cloud_delta_writer.cpp

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -121,7 +121,9 @@ Status CloudDeltaWriter::commit_rowset() {
121121
}
122122

123123
// Handle normal rowset with data
124-
return _engine.meta_mgr().commit_rowset(*rowset_meta(), "");
124+
RETURN_IF_ERROR(_engine.meta_mgr().commit_rowset(*rowset_meta(), ""));
125+
rowset_builder()->register_uncommitted_rowset();
126+
return Status::OK();
125127
}
126128

127129
Status CloudDeltaWriter::_commit_empty_rowset() {
@@ -146,8 +148,4 @@ Status CloudDeltaWriter::set_txn_related_delete_bitmap() {
146148
return rowset_builder()->set_txn_related_delete_bitmap();
147149
}
148150

149-
void CloudDeltaWriter::register_uncommitted_rowset() {
150-
rowset_builder()->register_uncommitted_rowset();
151-
}
152-
153151
} // namespace doris

be/src/cloud/cloud_delta_writer.h

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -53,8 +53,6 @@ class CloudDeltaWriter final : public BaseDeltaWriter {
5353

5454
Status set_txn_related_delete_bitmap();
5555

56-
void register_uncommitted_rowset();
57-
5856
std::shared_ptr<ResourceContext> resource_context() { return _resource_ctx; }
5957

6058
private:

be/src/cloud/cloud_tablets_channel.cpp

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -261,11 +261,6 @@ Status CloudTabletsChannel::close(LoadChannel* parent, const PTabletWriterAddBlo
261261
it++;
262262
}
263263

264-
// 7. Register uncommitted rowsets for READ UNCOMMITTED visibility
265-
for (auto* writer : writers_to_commit) {
266-
writer->register_uncommitted_rowset();
267-
}
268-
269264
tablet_vec->Reserve(static_cast<int>(writers_to_commit.size()));
270265
for (auto* writer : writers_to_commit) {
271266
PTabletInfo* tablet_info = tablet_vec->Add();

0 commit comments

Comments
 (0)