reponse to the reviewer

Signed-off-by: zhengyu <[email protected]>

Author: freemandealer

be/src/cloud/cloud_internal_service.cpp

@@ -455,7 +455,7 @@ void CloudInternalServiceImpl::warm_up_rowset(google::protobuf::RpcController* c
         }
 
         for (int64_t segment_id = 0; segment_id < rs_meta.num_segments(); segment_id++) {
-            if (!config::enable_only_warm_up_idx) {
+            if (!config::file_cache_enable_only_warm_up_idx) {
                 auto segment_size = rs_meta.segment_file_size(segment_id);
                 auto download_done = [=, version = rs_meta.version()](Status st) {
                     DBUG_EXECUTE_IF("CloudInternalServiceImpl::warm_up_rowset.download_segment", {

be/src/cloud/cloud_tablet.cpp

@@ -426,7 +426,7 @@ void CloudTablet::add_rowsets(std::vector<RowsetSharedPtr> to_add, bool version_
                     }
                     // clang-format off
                     auto self = std::dynamic_pointer_cast<CloudTablet>(shared_from_this());
-                    if (!config::enable_only_warm_up_idx) {
+                    if (!config::file_cache_enable_only_warm_up_idx) {
                         _engine.file_cache_block_downloader().submit_download_task(io::DownloadFileMeta {
                                 .path = storage_resource.value()->remote_segment_path(*rowset_meta, seg_id),
                                 .file_size = rs->rowset_meta()->segment_file_size(seg_id),

be/src/cloud/cloud_warm_up_manager.cpp

@@ -249,7 +249,7 @@ void CloudWarmUpManager::handle_jobs() {
                 }
                 for (int64_t seg_id = 0; seg_id < rs->num_segments(); seg_id++) {
                     // 1st. download segment files
-                    if (!config::enable_only_warm_up_idx) {
+                    if (!config::file_cache_enable_only_warm_up_idx) {
                         submit_download_tasks(
                                 storage_resource.value()->remote_segment_path(*rs, seg_id),
                                 rs->segment_file_size(cast_set<int>(seg_id)),

be/src/common/config.cpp

@@ -1167,7 +1167,7 @@ DEFINE_mInt64(file_cache_background_lru_dump_tail_record_num, "5000000");
 DEFINE_mInt64(file_cache_background_lru_log_replay_interval_ms, "1000");
 DEFINE_mBool(enable_evaluate_shadow_queue_diff, "false");
 
-DEFINE_mBool(enable_only_warm_up_idx, "false");
+DEFINE_mBool(file_cache_enable_only_warm_up_idx, "false");
 
 DEFINE_Int32(file_cache_downloader_thread_num_min, "32");
 DEFINE_Int32(file_cache_downloader_thread_num_max, "32");

be/src/common/config.h

@@ -1209,7 +1209,7 @@ DECLARE_mInt64(file_cache_background_lru_dump_tail_record_num);
 DECLARE_mInt64(file_cache_background_lru_log_replay_interval_ms);
 DECLARE_mBool(enable_evaluate_shadow_queue_diff);
 
-DECLARE_mBool(enable_only_warm_up_idx);
+DECLARE_mBool(file_cache_enable_only_warm_up_idx);
 
 // inverted index searcher cache
 // cache entry stay time after lookup