[bugfix](load) Add disk capacity check for downstream BE nodes in memtable-on-sink mode #51760
+28
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 34318 ms |
TPC-DS: Total hot run time: 192821 ms |
ClickBench: Total hot run time: 28.72 s |
Contributor
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 35322 ms |
TPC-DS: Total hot run time: 194907 ms |
ClickBench: Total hot run time: 29.83 s |
Contributor
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 33918 ms |
TPC-DS: Total hot run time: 185872 ms |
ClickBench: Total hot run time: 29.35 s |
Contributor
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
dataroaring
force-pushed
the
see-master
branch
from
53b8536 to
5041aa3
Compare
Contributor
|
run buildall |
TPC-H: Total hot run time: 35476 ms |
TPC-DS: Total hot run time: 188194 ms |
ClickBench: Total hot run time: 30.77 s |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 34912 ms |
TPC-DS: Total hot run time: 188882 ms |
TPC-DS: Total hot run time: 190632 ms |
ClickBench: Total hot run time: 30.38 s |
Contributor
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
Author
|
run cloud_p0 |
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
dataroaring
force-pushed
the
see-master
branch
from
95bad35 to
879f459
Compare
Contributor
|
run buildall |
0AyanamiRei
approved these changes
Nov 13, 2025
| RETURN_IF_ERROR(_rowset_builder->init()); | ||
| _rowset_writer = _rowset_builder->rowset_writer(); | ||
|
|
||
| auto tablet_res = ExecEnv::get_tablet(_req.tablet_id); |
Contributor
There was a problem hiding this comment.
u are absolutely right!
However, personally, for variables that are only used within an if statement, I would adopt this approach:
if (auto tablet_res = ExecEnv::get_tablet(_req.tablet_id); tablet_res.has_value()) {...}
if u think so, u can rewrite it~
Contributor
Author
There was a problem hiding this comment.
That's a very good suggestion, I will modify it.
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
felixwluo
force-pushed
the
see-master
branch
from
879f459 to
ff95c0c
Compare
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 35602 ms |
TPC-DS: Total hot run time: 187533 ms |
ClickBench: Total hot run time: 27.54 s |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
Author
|
run cloud_p0 |
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
dataroaring
force-pushed
the
see-master
branch
from
f626831 to
d073dc4
Compare
Contributor
|
run buildall |
TPC-H: Total hot run time: 32034 ms |
TPC-DS: Total hot run time: 172402 ms |
ClickBench: Total hot run time: 26.88 s |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #51735
Problem Summary:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)