Skip to content

Conversation

@zclllyybb
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

when we use auto partition and auto increment column at the same time, the _batching_block for auto partition will write again. so also fill increment column twice. if at the same time there's complex column substitution, the second time we write the _batching_block we may treat a wrong column as inc column. it may coredump or write wrong data into target table.
a typical core stack is:

assert_cast.h:49] Bad cast from type:doris::vectorized::ColumnVector<int>* to doris::vectorized::ColumnStr<unsigned int> const*
*** Check failure stack trace: ***
    @     0x55daad57a906  google::LogMessageFatal::~LogMessageFatal()
    @     0x55daa2b1beb0  _ZZ11assert_castIPKN5doris10vectorized9ColumnStrIjEEL18TypeCheckOnRelease1EPKNS1_7IColumnEET_OT1_ENKUlOSA_E_clIS9_EES5_SD_
    @     0x55daa2b1bcb7  assert_cast<>()
    @     0x55daac65b83f  doris::vectorized::OlapTableBlockConvertor::_internal_validate_column()
    @     0x55daac660465  doris::vectorized::OlapTableBlockConvertor::_validate_column()
    @     0x55daac65abc2  doris::vectorized::OlapTableBlockConvertor::_validate_data()
    @     0x55daac65987f  doris::vectorized::OlapTableBlockConvertor::validate_and_convert_block()
    @     0x55daaca1f4ed  doris::vectorized::VRowDistribution::generate_rows_distribution()
    @     0x55daaca07179  doris::vectorized::VTabletWriter::write()
    @     0x55daaca06dcf  doris::vectorized::VTabletWriter::_send_new_partition_batch()
    @     0x55daaca06fb5  doris::vectorized::VTabletWriter::write()
    @     0x55daac9d0d54  doris::vectorized::AsyncResultWriter::process_block()

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@zclllyybb zclllyybb requested a review from morrySnow as a code owner December 29, 2025 10:01
@zclllyybb
Copy link
Contributor Author

run buildall

@zclllyybb
Copy link
Contributor Author

run buildall

@zclllyybb
Copy link
Contributor Author

run buildall

@zclllyybb
Copy link
Contributor Author

run buildall

@hello-stephen
Copy link
Contributor

BE UT Coverage Report

Increment line coverage 0.00% (0/28) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 45.82% (12967/28299)
Line Coverage 36.69% (116165/316596)
Region Coverage 34.23% (66200/193398)
Branch Coverage 31.24% (34754/111256)

@zclllyybb
Copy link
Contributor Author

run buildall

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants