Skip to content

Commit c36bb7a

Browse files
Kunal Khatuasohami
authored andcommitted
DRILL-7202: Failed query shows warning that fragments made no progress
This bug arises because of the `toggleWarning()` javascript function that shows the warning if the number of slow major fragments matches the number of major fragments. For failed queries, the number of major fragments = 0; and that matches the number of tags (which is also zero for a non-running query). Hence the warning shows.
1 parent a148aac commit c36bb7a

File tree

1 file changed

+3
-1
lines changed
  • exec/java-exec/src/main/resources/rest/profile

1 file changed

+3
-1
lines changed

exec/java-exec/src/main/resources/rest/profile/profile.ftl

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,9 @@
5757
//No Progress Warning
5858
let noProgressFragmentCount = document.querySelectorAll('td[class=no-progress-tag]').length;
5959
let majorFragmentCount = document.querySelectorAll('#fragment-overview table tbody tr').length;
60-
toggleWarning("noProgressWarning", majorFragmentCount, noProgressFragmentCount);
60+
if (majorFragmentCount > 0) { // For fast-failed queries majorFragmentCount=0
61+
toggleWarning("noProgressWarning", majorFragmentCount, noProgressFragmentCount);
62+
}
6163
6264
//Spill To Disk Warnings
6365
let spillCount = document.querySelectorAll('td[class=spill-tag]').length;

0 commit comments

Comments
 (0)