Skip to content

Commit 2427b34

Browse files
committed
Remove unnecessary comments
1 parent 1d29d7f commit 2427b34

File tree

3 files changed

+14
-19
lines changed

3 files changed

+14
-19
lines changed

processing/src/main/java/org/apache/druid/query/groupby/GroupByQueryQueryToolChest.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -209,8 +209,6 @@ private Sequence<ResultRow> initAndMergeGroupByResults(
209209

210210
private void populateQueryMetrics(GroupByQueryMetrics queryMetrics, ResponseContext context)
211211
{
212-
// TODO: Everything is working as expected now, but the GroupByQueryMetrics expects to emit the metrics directly.
213-
// Why not we also send the values individually to the GroupByStatsMonitor?
214212
Object bytesSpilledToStorage = context.get(GroupByResponseContextKeys.GROUPBY_BYTES_SPILLED_TO_STORAGE_KEY);
215213

216214
if (bytesSpilledToStorage != null) {

processing/src/main/java/org/apache/druid/query/groupby/epinephelinae/ConcurrentGrouper.java

Lines changed: 14 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -414,22 +414,20 @@ private List<CloseableIterator<Entry<KeyType>>> parallelSortAndGetGroupersIterat
414414
{
415415
// The number of groupers is same with the number of processing threads in the executor
416416
final List<ListenableFuture<CloseableIterator<Entry<KeyType>>>> futures = groupers.stream()
417-
.map(grouper ->
418-
executor.submit(
419-
new AbstractPrioritizedCallable<CloseableIterator<Entry<KeyType>>>(
420-
priority)
421-
{
422-
@Override
423-
public CloseableIterator<Entry<KeyType>> call()
424-
{
425-
return grouper.iterator(
426-
true);
427-
}
428-
}
429-
)
430-
)
431-
.collect(Collectors.toList()
432-
);
417+
.map(grouper ->
418+
executor.submit(
419+
new AbstractPrioritizedCallable<CloseableIterator<Entry<KeyType>>>(priority)
420+
{
421+
@Override
422+
public CloseableIterator<Entry<KeyType>> call()
423+
{
424+
return grouper.iterator(true);
425+
}
426+
}
427+
)
428+
)
429+
.collect(Collectors.toList()
430+
);
433431

434432
ListenableFuture<List<CloseableIterator<Entry<KeyType>>>> future = Futures.allAsList(futures);
435433
try {

processing/src/main/java/org/apache/druid/query/groupby/epinephelinae/GroupByMergingQueryRunner.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -146,7 +146,6 @@ public Sequence<ResultRow> run(final QueryPlus<ResultRow> queryPlus, final Respo
146146
CTX_KEY_MERGE_RUNNERS_USING_CHAINED_EXECUTION,
147147
false
148148
);
149-
150149
final QueryPlus<ResultRow> queryPlusForRunners = queryPlus
151150
.withQuery(
152151
query.withOverriddenContext(ImmutableMap.of(CTX_KEY_MERGE_RUNNERS_USING_CHAINED_EXECUTION, true))

0 commit comments

Comments
 (0)