Make it easier to review this change

Author: GWphua

server/src/main/java/org/apache/druid/segment/loading/SegmentLocalCacheManager.java

@@ -228,23 +228,24 @@ public List<DataSegment> getCachedSegments() throws IOException
       }
     }
 
-    final File[] segmentsToLoad = retrieveSegmentMetadataFiles();
     final ConcurrentLinkedQueue<DataSegment> cachedSegments = new ConcurrentLinkedQueue<>();
-    AtomicInteger ignoredFilesCounter = new AtomicInteger(0);
+    final File[] segmentsToLoad = retrieveSegmentMetadataFiles();
     CountDownLatch latch = new CountDownLatch(segmentsToLoad.length);
 
     boolean createdNewExecutorServiceToLoadSegmentCache = loadOnBootstrapExec == null;
     ExecutorService executorService = createdNewExecutorServiceToLoadSegmentCache
                                       ? MoreExecutors.newDirectExecutorService()
                                       : loadOnBootstrapExec;
 
+    AtomicInteger ignoredFilesCounter = new AtomicInteger(0);
+
     Stopwatch stopwatch = Stopwatch.createStarted();
     log.info("Retrieving [%d] cached segment metadata files to cache.", segmentsToLoad.length);
 
     for (File file : segmentsToLoad) {
       executorService.submit(() -> {
         try {
-          loadToCachedSegmentsFromFile(cachedSegments, file, ignoredFilesCounter);
+          addFilesToCachedSegments(file, ignoredFilesCounter, cachedSegments);
         }
         catch (Exception e) {
           log.makeAlert(e, "Failed to load segment from segment cache file.")
@@ -281,10 +282,10 @@ public List<DataSegment> getCachedSegments() throws IOException
     return new ArrayList<>(cachedSegments);
   }
 
-  private void loadToCachedSegmentsFromFile(
-      ConcurrentLinkedQueue<DataSegment> cachedSegments,
+  private void addFilesToCachedSegments(
       File file,
-      AtomicInteger ignored
+      AtomicInteger ignored,
+      ConcurrentLinkedQueue<DataSegment> cachedSegments
   ) throws IOException
   {
     final DataSegment segment = jsonMapper.readValue(file, DataSegment.class);