Skip to content

Commit 9cfc715

Browse files
authored
Migrate flaky ITNestedQueryPushDownTest to embedded test (#18807)
* Add embedded test ForcePushdownNestedQuery (to replace the existing flaky IT). The ITNestedQueryPushDownTest has recently been very flaky. So this patch migrates it to the Embedded test framework and hopefully should resolve any flakiness in this IT for good. * Remove references to the old IT: ITNestedQueryPushDownTest * Original native queries for completeness. * Review suggestion: break down into native and sql queries each
1 parent 57b2b3d commit 9cfc715

File tree

6 files changed

+424
-490
lines changed

6 files changed

+424
-490
lines changed

.github/workflows/standard-its.yml

Lines changed: 1 addition & 59 deletions
Original file line numberDiff line numberDiff line change
@@ -112,62 +112,4 @@ jobs:
112112
testing_groups: -Dgroups=custom-coordinator-duties
113113
use_indexer: middleManager
114114
override_config_path: ./environment-configs/test-groups/custom-coordinator-duties
115-
group: custom coordinator duties
116-
117-
integration-k8s-leadership-tests:
118-
needs: changes
119-
name: (Compile=openjdk17, Run=openjdk17, Cluster Build On K8s) ITNestedQueryPushDownTest integration test
120-
if: ${{ needs.changes.outputs.core == 'true' || needs.changes.outputs.common-extensions == 'true' }}
121-
runs-on: ubuntu-22.04
122-
env:
123-
MVN: mvn --no-snapshot-updates
124-
MAVEN_SKIP: -P skip-static-checks -Dweb.console.skip=true -Dmaven.javadoc.skip=true
125-
CONFIG_FILE: k8s_run_config_file.json
126-
IT_TEST: -Dit.test=ITNestedQueryPushDownTest
127-
POD_NAME: int-test
128-
POD_NAMESPACE: default
129-
BUILD_DRUID_CLUSTER: true
130-
steps:
131-
- name: Checkout branch
132-
uses: actions/checkout@v4
133-
134-
- name: setup java
135-
uses: actions/setup-java@v4
136-
with:
137-
java-version: '17'
138-
distribution: 'zulu'
139-
140-
# the build step produces SNAPSHOT artifacts into the local maven repository,
141-
# we include github.sha in the cache key to make it specific to that build/jdk
142-
- name: Restore Maven repository
143-
id: maven-restore
144-
uses: actions/cache/restore@v4
145-
with:
146-
path: ~/.m2/repository
147-
key: maven-${{ runner.os }}-17-${{ github.sha }}
148-
restore-keys: setup-java-Linux-maven-${{ hashFiles('**/pom.xml') }}
149-
150-
- name: Maven build
151-
if: steps.maven-restore.outputs.cache-hit != 'true'
152-
run: |
153-
./it.sh ci
154-
155-
- name: Run IT
156-
id: test
157-
timeout-minutes: 90
158-
run: |
159-
set -x
160-
mvn -B -ff install -pl '!web-console' -Pdist,bundle-contrib-exts -Pskip-static-checks,skip-tests -Dmaven.javadoc.skip=true -T1C
161-
# Note: The above command relies on the correct version of the JARs being installed in the local m2 repository.
162-
# For any changes, please rebuild it using the command from the previous step (./it.sh ci).
163-
164-
MAVEN_OPTS='-Xmx2048m' ${MVN} verify -pl integration-tests -P int-tests-config-file ${IT_TEST} ${MAVEN_SKIP} -Dpod.name=${POD_NAME} -Dpod.namespace=${POD_NAMESPACE} -Dbuild.druid.cluster=${BUILD_DRUID_CLUSTER}
165-
166-
- name: Debug on failure
167-
if: ${{ failure() && steps.test.conclusion == 'failure' }}
168-
run: |
169-
for v in broker middlemanager router coordinator historical ; do
170-
echo "------------------------druid-tiny-cluster-"$v"s-0-------------------------";
171-
/usr/local/bin/kubectl logs --tail 1000 druid-tiny-cluster-"$v"s-0 ||:;
172-
/usr/local/bin/kubectl get events | grep druid-tiny-cluster-"$v"s-0 ||:;
173-
done
115+
group: custom coordinator duties

0 commit comments

Comments
 (0)