Skip to content

Commit b3f6a23

Browse files
capistrantgianmcryptoe
authored
MSQ: Fix composing channels losing partitionless frames. (#18220) (#18267)
* MSQ: Fix composing channels losing partitionless frames. The main change is that single-partition ComposingWritableFrameChannels (i.e. those created by `ChannelOutputFactory#openChannel`) now associate all incoming frames with that partition. Previously, frames might have come in with partition set to `NO_PARTITION`, which would cause them to get "lost" by the composing channel. Fixes a bug introduced in #18144 when composed intermediate stage-internal channels started being used for the output of hash partitioning. Prior to #18144, they were only used for internal channels of the SuperSorter. This bug could cause frames to go missing during sortMerge joins. This patch also adds an embedded test for various durable storage scenarios, including sortMerge join tests that would have caught the original bug. Finally, this patch adjusts the way that Calcites escapes string literals, to use the actual characters more often when possible. This helps format the test SQLs generated by the embedded test more nicely. * dependency analyze. --------- Co-authored-by: Gian Merlino <gianmerlino@gmail.com> Co-authored-by: Karan Kumar <karankumar1100@gmail.com>
1 parent cc93015 commit b3f6a23

File tree

13 files changed

+602
-8
lines changed

13 files changed

+602
-8
lines changed

embedded-tests/pom.xml

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -182,6 +182,16 @@
182182
<groupId>junit</groupId>
183183
<artifactId>junit</artifactId>
184184
</dependency>
185+
<dependency>
186+
<groupId>org.hamcrest</groupId>
187+
<artifactId>hamcrest-all</artifactId>
188+
<scope>test</scope>
189+
</dependency>
190+
<dependency>
191+
<groupId>org.hamcrest</groupId>
192+
<artifactId>hamcrest-core</artifactId>
193+
<scope>test</scope>
194+
</dependency>
185195
<dependency>
186196
<groupId>org.apache.curator</groupId>
187197
<artifactId>curator-test</artifactId>

0 commit comments

Comments
 (0)