Skip to content

Commit b4f8613

Browse files
committed
Restructure.
1 parent 67c6157 commit b4f8613

File tree

1 file changed

+30
-27
lines changed

1 file changed

+30
-27
lines changed

indexing-service/src/main/java/org/apache/druid/indexing/common/task/CompactionTask.java

Lines changed: 30 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -784,35 +784,38 @@ private static Pair<DataSegment, Supplier<ResourceHolder<QueryableIndex>>> fetch
784784
SegmentCacheManager segmentCacheManager
785785
)
786786
{
787-
return Pair.of(
788-
dataSegment,
789-
() -> {
790-
final Closer closer = Closer.create();
791-
try {
792-
final AcquireSegmentAction acquireAction = closer.register(segmentCacheManager.acquireSegment(dataSegment));
793-
final ReferenceCountedObjectProvider<Segment> segmentProvider =
794-
FutureUtils.getUnchecked(acquireAction.getSegmentFuture(), true).getReferenceProvider();
795-
final Segment segment = segmentProvider.acquireReference().map(closer::register).get();
796-
return new ResourceHolder<>()
797-
{
798-
@Override
799-
public QueryableIndex get()
800-
{
801-
return segment.as(QueryableIndex.class);
802-
}
787+
return Pair.of(dataSegment, () -> fetchSegmentInternal(dataSegment, segmentCacheManager));
788+
}
803789

804-
@Override
805-
public void close()
806-
{
807-
CloseableUtils.closeAndWrapExceptions(closer);
808-
}
809-
};
810-
}
811-
catch (Exception e) {
812-
throw CloseableUtils.closeAndWrapInCatch(e, closer);
813-
}
790+
private static ResourceHolder<QueryableIndex> fetchSegmentInternal(
791+
DataSegment dataSegment,
792+
SegmentCacheManager segmentCacheManager
793+
)
794+
{
795+
final Closer closer = Closer.create();
796+
try {
797+
final AcquireSegmentAction acquireAction = closer.register(segmentCacheManager.acquireSegment(dataSegment));
798+
final ReferenceCountedObjectProvider<Segment> segmentProvider =
799+
FutureUtils.getUnchecked(acquireAction.getSegmentFuture(), true).getReferenceProvider();
800+
final Segment segment = segmentProvider.acquireReference().map(closer::register).get();
801+
return new ResourceHolder<>()
802+
{
803+
@Override
804+
public QueryableIndex get()
805+
{
806+
return segment.as(QueryableIndex.class);
814807
}
815-
);
808+
809+
@Override
810+
public void close()
811+
{
812+
CloseableUtils.closeAndWrapExceptions(closer);
813+
}
814+
};
815+
}
816+
catch (Exception e) {
817+
throw CloseableUtils.closeAndWrapInCatch(e, closer);
818+
}
816819
}
817820

818821
/**

0 commit comments

Comments
 (0)