Skip to content

Commit ef46541

Browse files
authored
Include JDK version in test-reports so it's easier to find (#18817)
Currently, we generate a single consolidated test-report across both JDK 17 and JDK 21. Some tests may fail or flake only on one JDK version, which makes it harder to identify the source of the error. This patch generates a separate test report per JDK version, which will allow us to identify the source of a failure by checking the corresponding JDK-specific job.
1 parent 0b4bbbc commit ef46541

File tree

1 file changed

+7
-3
lines changed

1 file changed

+7
-3
lines changed

.github/workflows/ci.yml

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ jobs:
2929
uses: ./.github/workflows/worker.yml
3030
with:
3131
script: .github/scripts/run_unit-tests -Dtest=!QTest,'${{ matrix.pattern }}' -Dmaven.test.failure.ignore=true
32-
artifact_prefix: "unit-test-reports"
32+
artifact_prefix: "unit-test-reports-jdk${{ matrix.jdk }}"
3333
jdk: ${{ matrix.jdk }}
3434
key: "test-jdk${{ matrix.jdk }}-[${{ matrix.pattern }}]"
3535

@@ -43,17 +43,21 @@ jobs:
4343
name: "test-report"
4444
needs: run-unit-tests
4545
runs-on: ubuntu-latest
46+
strategy:
47+
fail-fast: false
48+
matrix:
49+
jdk: [ "17", "21" ]
4650
steps:
4751
- name: Download reports for all unit test jobs
4852
uses: actions/download-artifact@v4
4953
with:
50-
pattern: "unit-test-reports-*"
54+
pattern: "unit-test-reports-jdk${{ matrix.jdk }}*"
5155
path: target/surefire-reports
5256

5357
- name: Publish Test Report
5458
uses: mikepenz/action-junit-report@v5
5559
with:
56-
check_name: "Unit Test Report"
60+
check_name: "Unit Test Report (JDK ${{ matrix.jdk }})"
5761
report_paths: '**/target/surefire-reports/TEST-*.xml'
5862
detailed_summary: true
5963
flaky_summary: true

0 commit comments

Comments
 (0)