Skip to content

Commit f44be2f

Browse files
committed
Revert logging changes
1 parent 5033413 commit f44be2f

File tree

5 files changed

+0
-18
lines changed

5 files changed

+0
-18
lines changed

server/src/main/java/org/apache/druid/query/lookup/LookupModule.java

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,6 @@
3232
import org.apache.druid.guice.LazySingleton;
3333
import org.apache.druid.guice.LifecycleModule;
3434
import org.apache.druid.initialization.DruidModule;
35-
import org.apache.druid.java.util.common.logger.Logger;
3635
import org.apache.druid.query.dimension.LookupDimensionSpec;
3736
import org.apache.druid.query.expression.LookupExprMacro;
3837
import org.apache.druid.server.initialization.jetty.JettyBindings;
@@ -43,15 +42,13 @@
4342

4443
public class LookupModule implements DruidModule
4544
{
46-
private static final Logger log = new Logger(LookupModule.class);
4745
static final String PROPERTY_BASE = "druid.lookup";
4846
public static final String FAILED_UPDATES_KEY = "failedUpdates";
4947
public static final int LOOKUP_LISTENER_QOS_MAX_REQUESTS = 2;
5048

5149
@Override
5250
public List<? extends Module> getJacksonModules()
5351
{
54-
log.info("Umm yes LookupModule.getJacksonModules()");
5552
return ImmutableList.<Module>of(
5653
new SimpleModule("DruidLookupModule").registerSubtypes(MapLookupExtractorFactory.class),
5754
new SimpleModule().registerSubtypes(
@@ -64,7 +61,6 @@ public List<? extends Module> getJacksonModules()
6461
@Override
6562
public void configure(Binder binder)
6663
{
67-
log.info("Umm yes LookupModule.configure()");
6864
JsonConfigProvider.bind(binder, PROPERTY_BASE, LookupConfig.class);
6965
binder.bind(LookupExtractorFactoryContainerProvider.class).to(LookupReferencesManager.class);
7066
LifecycleModule.register(binder, LookupReferencesManager.class);
@@ -83,7 +79,6 @@ public void configure(Binder binder)
8379
@LazySingleton
8480
public LookupNodeService getLookupNodeService(LookupListeningAnnouncerConfig lookupListeningAnnouncerConfig)
8581
{
86-
log.info("Umm yes LookupModule.getLookupNodeService()");
8782
return new LookupNodeService(lookupListeningAnnouncerConfig.getLookupTier());
8883
}
8984
}

server/src/main/java/org/apache/druid/query/lookup/LookupReferencesManager.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -118,7 +118,6 @@ public LookupReferencesManager(
118118
)
119119
{
120120
this(lookupConfig, objectMapper, coordinatorClient, lookupListeningAnnouncerConfig, false);
121-
LOG.info("Umm Initializing LookupReferencesManager");
122121
}
123122

124123
@VisibleForTesting

services/src/main/java/org/apache/druid/cli/CliPeon.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -325,7 +325,6 @@ public Task readTask(@Json ObjectMapper mapper, ExecutorLifecycleConfig config,
325325
// write the remote task.json to the task file location for ExecutorLifecycle to pickup
326326
FileUtils.write(config.getTaskFile(), task, Charset.defaultCharset());
327327
}
328-
log.info("Grrr read task from config.getTaskFile() [%s]", config.getTaskFile());
329328
return mapper.readValue(config.getTaskFile(), Task.class);
330329
}
331330
catch (IOException e) {

services/src/main/java/org/apache/druid/cli/CliPeonLoadSpecHolder.java

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,6 @@
2323
import com.google.inject.Provider;
2424
import org.apache.druid.error.DruidException;
2525
import org.apache.druid.indexing.common.task.Task;
26-
import org.apache.druid.java.util.common.logger.Logger;
2726
import org.apache.druid.server.coordination.BroadcastDatasourceLoadingSpec;
2827
import org.apache.druid.server.lookup.cache.LookupLoadingSpec;
2928
import org.apache.druid.server.metrics.LoadSpecHolder;
@@ -36,16 +35,13 @@
3635
*/
3736
public class CliPeonLoadSpecHolder implements LoadSpecHolder
3837
{
39-
private static final Logger log = new Logger(CliPeonLoadSpecHolder.class);
40-
4138
private Provider<Task> taskProvider;
4239

4340
@Inject
4441
public CliPeonLoadSpecHolder(
4542
Provider<Task> taskProvider
4643
)
4744
{
48-
log.info("GRRRONCE NewTaskLoadSpecHolder with [%s]", taskProvider);
4945
this.taskProvider = taskProvider;
5046
}
5147

@@ -54,7 +50,6 @@ public CliPeonLoadSpecHolder(
5450
public LookupLoadingSpec getLookupLoadingSpec()
5551
{
5652
final Task task = taskProvider.get();
57-
log.info("GRRR NewTaskLoadSpecHolder.getLookupLoadingSpec() task[%s]", task);
5853
if (task == null) {
5954
throw DruidException.defensive("blah");
6055
}
@@ -65,7 +60,6 @@ public LookupLoadingSpec getLookupLoadingSpec()
6560
public BroadcastDatasourceLoadingSpec getBroadcastDatasourceLoadingSpec()
6661
{
6762
final Task task = taskProvider.get();
68-
log.info("GRRR NewTaskLoadSpecHolder.getBroadcastDatasourceLoadingSpec() task[%s]", task);
6963
if (task == null) {
7064
throw DruidException.defensive("blah");
7165
}

services/src/main/java/org/apache/druid/cli/CliPeonTaskHolder.java

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,6 @@
2323
import com.google.inject.Provider;
2424
import org.apache.druid.error.DruidException;
2525
import org.apache.druid.indexing.common.task.Task;
26-
import org.apache.druid.java.util.common.logger.Logger;
2726
import org.apache.druid.server.metrics.TaskHolder;
2827

2928
/**
@@ -34,23 +33,20 @@
3433
*/
3534
public class CliPeonTaskHolder implements TaskHolder
3635
{
37-
private static final Logger log = new Logger(CliPeonTaskHolder.class);
3836
private Provider<Task> taskProvider;
3937

4038
@Inject
4139
public CliPeonTaskHolder(
4240
Provider<Task> taskProvider
4341
)
4442
{
45-
log.info("GRRRONCE NewTaskPropertiesHolder with [%s]", taskProvider);
4643
this.taskProvider = taskProvider;
4744
}
4845

4946
@Override
5047
public String getDataSource()
5148
{
5249
final Task task = taskProvider.get();
53-
log.info("GRRR NewTaskPropertiesHolder.getDataSource() task[%s]", task);
5450
if (task == null) {
5551
throw DruidException.defensive("blah");
5652
}
@@ -61,7 +57,6 @@ public String getDataSource()
6157
public String getTaskId()
6258
{
6359
final Task task = taskProvider.get();
64-
log.info("GRRR NewTaskPropertiesHolder.getDataSource() task[%s]", task);
6560
if (task == null) {
6661
throw DruidException.defensive("blah");
6762
}

0 commit comments

Comments
 (0)