feat: unified error code; separate application handler and service into parts

Author: robocanic

pkg/common/bizerror/common.go

@@ -18,38 +18,15 @@
 package bizerror
 
 import (
-	"errors"
 	"fmt"
 )
 
-type AssertionError struct {
-	msg string
+func NewAssertionError(expected, actual interface{}) Error {
+	return NewBizError(UnknownError, fmt.Sprintf("type assertion error, expected:%v, actual:%v", expected, actual))
 }
-
-func NewAssertionError(expected, actual interface{}) error {
-	return &AssertionError{
-		msg: fmt.Sprintf("type assertion error, expected:%v, actual:%v", expected, actual),
-	}
-}
-
-func (e *AssertionError) Error() string {
-	return e.msg
-}
-
-type MeshNotFoundError struct {
-	Mesh string
+func NewUnauthorizedError() Error {
+	return NewBizError(Unauthorized, "no access, please login")
 }
-
-func (m *MeshNotFoundError) Error() string {
-	return fmt.Sprintf("mesh of name %s is not found", m.Mesh)
-}
-
-func MeshNotFound(meshName string) error {
-	return &MeshNotFoundError{meshName}
-}
-
-func IsMeshNotFound(err error) bool {
-	var meshNotFoundError *MeshNotFoundError
-	ok := errors.As(err, &meshNotFoundError)
-	return ok
+func MeshNotFoundError(mesh string) Error {
+	return NewBizError(UnknownError, fmt.Sprintf("mesh of name %s is not found", mesh))
 }

pkg/common/bizerror/error.go

@@ -0,0 +1,44 @@
+package bizerror
+
+type Error interface {
+	Code() ErrorCode
+	Message() string
+	Error() string
+}
+
+type ErrorCode string
+
+const (
+	UnknownError    ErrorCode = "UnknownError"
+	InvalidArgument ErrorCode = "InvalidArgument"
+	StoreError      ErrorCode = "StoreError"
+	AppNotFound     ErrorCode = "AppNotFound"
+	Unauthorized    ErrorCode = "Unauthorized"
+	SessionError    ErrorCode = "SessionError"
+)
+
+type bizError struct {
+	code    ErrorCode
+	message string
+}
+
+var _ Error = &bizError{}
+
+func NewBizError(code ErrorCode, message string) Error {
+	return &bizError{
+		code:    code,
+		message: message,
+	}
+}
+
+func (b *bizError) Code() ErrorCode {
+	return b.code
+}
+
+func (b *bizError) Message() string {
+	return b.message
+}
+
+func (b *bizError) Error() string {
+	return string(b.code) + ": " + b.message
+}

pkg/console/component.go

@@ -30,6 +30,7 @@ import (
 	"github.com/gin-gonic/gin"
 
 	ui "github.com/apache/dubbo-admin/app/dubbo-ui"
+	"github.com/apache/dubbo-admin/pkg/common/bizerror"
 	"github.com/apache/dubbo-admin/pkg/config/console"
 	consolectx "github.com/apache/dubbo-admin/pkg/console/context"
 	"github.com/apache/dubbo-admin/pkg/console/model"
@@ -130,7 +131,8 @@ func (c *consoleWebServer) authMiddleware() gin.HandlerFunc {
 		session := sessions.Default(c)
 		user := session.Get("user")
 		if user == nil {
-			c.JSON(http.StatusUnauthorized, model.NewUnauthorizedResp())
+			err := bizerror.NewAssertionError(bizerror.UnknownError, "please login")
+			c.JSON(http.StatusUnauthorized, model.NewBizErrorResp(err))
 			c.Abort()
 			return
 		}