Skip to content

Commit e09a88e

Browse files
committed
Resolve merge conflict in pkg/common/bizerror/error.go
2 parents 4eb3a8d + 8608e59 commit e09a88e

File tree

98 files changed

+5468
-977
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

98 files changed

+5468
-977
lines changed

api/mesh/v1alpha1/condition_route_helper.go

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -23,15 +23,15 @@ import (
2323
"github.com/pkg/errors"
2424
"sigs.k8s.io/yaml"
2525

26+
"github.com/apache/dubbo-admin/pkg/common/constants"
2627
"github.com/apache/dubbo-admin/pkg/common/util/proto"
27-
"github.com/apache/dubbo-admin/pkg/core/consts"
2828
)
2929

3030
func (x *ConditionRoute) GetVersion() string {
3131
if x.ToConditionRouteV3() != nil {
32-
return consts.ConfiguratorVersionV3
32+
return constants.ConfiguratorVersionV3
3333
} else {
34-
return consts.ConfiguratorVersionV3x1
34+
return constants.ConfiguratorVersionV3x1
3535
}
3636
}
3737

@@ -51,17 +51,17 @@ func ConditionRouteDecodeFromYAML(content []byte) (*ConditionRoute, error) {
5151
return nil, err
5252
}
5353

54-
version, ok := _map[consts.ConfigVersionKey].(string)
54+
version, ok := _map[constants.ConfigVersionKey].(string)
5555
if !ok {
5656
return nil, errors.New("invalid condition route format")
5757
}
58-
if version == consts.ConfiguratorVersionV3 {
58+
if version == constants.ConfiguratorVersionV3 {
5959
v3 := new(ConditionRouteV3)
6060
if err = proto.FromYAML(content, v3); err != nil {
6161
return nil, err
6262
}
6363
return v3.ToConditionRoute(), nil
64-
} else if version == consts.ConfiguratorVersionV3x1 {
64+
} else if version == constants.ConfiguratorVersionV3x1 {
6565
v3x1 := new(ConditionRouteV3X1)
6666
if err = proto.FromYAML(content, v3x1); err != nil {
6767
return nil, err
@@ -133,7 +133,7 @@ func (x *ConditionRule) IsMatchMethod() (string, bool) {
133133
conditions := strings.Split(x.From.Match, "&")
134134
for _, condition := range conditions {
135135
if idx := strings.Index(condition, "method"); idx != -1 {
136-
args := strings.Split(condition, consts.Equal)
136+
args := strings.Split(condition, constants.Equal)
137137
if len(args) == 2 {
138138
return strings.TrimSpace(args[1]), true
139139
}

api/mesh/v1alpha1/dynamic_config.proto

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@ message DynamicConfig {
1212
option (dubbo.mesh.resource).plural_name = "DynamicConfigs";
1313
option (dubbo.mesh.resource).package = "mesh";
1414
option (dubbo.mesh.resource).is_experimental = false;
15-
1615
string key = 1;
1716
string scope = 2;
1817
string configVersion = 3;

api/mesh/v1alpha1/dynamic_config_helper.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,12 +20,12 @@ package v1alpha1
2020
import (
2121
"strings"
2222

23-
"github.com/apache/dubbo-admin/pkg/core/consts"
23+
"github.com/apache/dubbo-admin/pkg/common/constants"
2424
)
2525

2626
func GetOverridePath(key string) string {
2727
key = strings.Replace(key, "/", "*", -1)
28-
return key + consts.ConfiguratorRuleSuffix
28+
return key + constants.ConfiguratorRuleSuffix
2929
}
3030

3131
func (d *DynamicConfig) ListUnGenConfigs() []*OverrideConfig {

api/mesh/v1alpha1/instance.pb.go

Lines changed: 87 additions & 76 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

api/mesh/v1alpha1/instance.proto

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -16,17 +16,16 @@ message Instance {
1616

1717
string name = 1;
1818

19-
string ip = 2;
19+
string appName = 2;
2020

21+
string ip = 3;
22+
23+
int64 rpcPort = 4;
2124
/*
2225
FROM RPCInstance
2326
*/
2427

25-
int32 rpcPort = 3;
26-
27-
int32 qosPort = 4;
28-
29-
string appName = 5;
28+
int64 qosPort = 5;
3029

3130
string releaseVersion = 6;
3231

@@ -38,9 +37,11 @@ message Instance {
3837

3938
string serialization = 10;
4039

40+
string preferSerialization = 11;
41+
4142
map<string, string> tags = 50;
4243

43-
reserved 11 to 49;
44+
reserved 12 to 49;
4445

4546
/*
4647
FROM RuntimeInstance

api/mesh/v1alpha1/nacos_config.pb.go

Lines changed: 146 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,19 @@
1+
syntax = "proto3";
2+
3+
package dubbo.mesh.v1alpha1;
4+
5+
option go_package = "github.com/apache/dubbo-admin/api/mesh/v1alpha1";
6+
7+
import "api/mesh/options.proto";
8+
9+
// Nacos config is the raw data of nacos configuration
10+
message NacosConfig {
11+
option (dubbo.mesh.resource).name = "NacosConfig";
12+
option (dubbo.mesh.resource).plural_name = "NacosConfigs";
13+
option (dubbo.mesh.resource).package = "mesh";
14+
option (dubbo.mesh.resource).is_experimental = true;
15+
16+
string dataId = 1;
17+
18+
string content = 2;
19+
}

0 commit comments

Comments
 (0)