Skip to content

Commit a8f34b9

Browse files
KapilSachdevKapilSachdev
committed
fix: Restore icons from element plus for now
- Add icon package via CDN - Register icons in main.js - Add svg for Document icon within JS code
1 parent 88cdabd commit a8f34b9

File tree

9 files changed

+29
-23
lines changed

9 files changed

+29
-23
lines changed

‎public/en/editor.html‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,7 @@
3030
<script src="https://fastly.jsdelivr.net/npm/[email protected]/dist/jquery.min.js"></script>
3131
<script src="https://fastly.jsdelivr.net/npm/[email protected]/dist/js/bootstrap.min.js"></script>
3232
<script src="https://fastly.jsdelivr.net/npm/[email protected]/dist/index.full.min.js"></script>
33+
<script src="https://fastly.jsdelivr.net/npm/@element-plus/[email protected]/dist/index.iife.min.js"></script>
3334
</head>
3435
<body>
3536
<div id="main"></div>

‎public/en/index.html‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,7 @@
3030
<script src="https://fastly.jsdelivr.net/npm/[email protected]/dist/jquery.min.js"></script>
3131
<script src="https://fastly.jsdelivr.net/npm/[email protected]/dist/js/bootstrap.min.js"></script>
3232
<script src="https://fastly.jsdelivr.net/npm/[email protected]/dist/index.full.min.js"></script>
33+
<script src="https://fastly.jsdelivr.net/npm/@element-plus/[email protected]/dist/index.iife.min.js"></script>
3334
</head>
3435
<body>
3536
<div id="main"></div>

‎public/en/view.html‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,7 @@
3030
<script src="https://fastly.jsdelivr.net/npm/[email protected]/dist/jquery.min.js"></script>
3131
<script src="https://fastly.jsdelivr.net/npm/[email protected]/dist/js/bootstrap.min.js"></script>
3232
<script src="https://fastly.jsdelivr.net/npm/[email protected]/dist/index.full.min.js"></script>
33+
<script src="https://fastly.jsdelivr.net/npm/@element-plus/[email protected]/dist/index.iife.min.js"></script>
3334
</head>
3435
<body>
3536
<div id="main"></div>

‎public/zh/editor.html‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,7 @@
3030
<script src="https://registry.npmmirror.com/jquery/3.7.1/files/dist/jquery.min.js"></script>
3131
<script src="https://lib.baomitu.com/twitter-bootstrap/3.4.1/js/bootstrap.min.js"></script>
3232
<script src="https://lib.baomitu.com/element-plus/2.11.4/index.full.min.js"></script>
33+
<script src="https://lib.baomitu.com/element-plus-icons-vue/2.3.2/index.iife.min.js"></script>
3334
</head>
3435
<body>
3536
<div id="main"></div>

‎public/zh/index.html‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,7 @@
3030
<script src="https://registry.npmmirror.com/jquery/3.7.1/files/dist/jquery.min.js"></script>
3131
<script src="https://lib.baomitu.com/twitter-bootstrap/3.4.1/js/bootstrap.min.js"></script>
3232
<script src="https://lib.baomitu.com/element-plus/2.11.4/index.full.min.js"></script>
33+
<script src="https://lib.baomitu.com/element-plus-icons-vue/2.3.2/index.iife.min.js"></script>
3334
</head>
3435
<body>
3536
<div id="main"></div>

‎public/zh/view.html‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,7 @@
3030
<script src="https://registry.npmmirror.com/jquery/3.7.1/files/dist/jquery.min.js"></script>
3131
<script src="https://lib.baomitu.com/twitter-bootstrap/3.4.1/js/bootstrap.min.js"></script>
3232
<script src="https://lib.baomitu.com/element-plus/2.11.4/index.full.min.js"></script>
33+
<script src="https://lib.baomitu.com/element-plus-icons-vue/2.3.2/index.iife.min.js"></script>
3334
</head>
3435
<body>
3536
<div id="main"></div>

‎src/editor/Editor.vue‎

Lines changed: 7 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -317,11 +317,9 @@
317317
<template #label>
318318
<span>
319319
{{ t('editor.prPreview.review') }}
320-
<i
321-
v-if="isPRReviewLoading"
322-
class="el-icon-loading"
323-
style="margin-left: 5px"
324-
></i>
320+
<el-icon v-if="isPRReviewLoading" style="margin-left: 5px">
321+
<Loading />
322+
</el-icon>
325323
</span>
326324
</template>
327325
<span v-if="isPRReviewLoading">{{
@@ -384,11 +382,9 @@
384382
<details @toggle="$event.target.open && loadPRDiff()">
385383
<summary style="display: revert; cursor: pointer">
386384
{{ t('editor.prPreview.viewDiff') }}
387-
<i
388-
v-if="isPRDiffLoading"
389-
class="el-icon-loading"
390-
style="margin-left: 5px"
391-
></i>
385+
<el-icon v-if="isPRDiffLoading" style="margin-left: 5px">
386+
<Loading />
387+
</el-icon>
392388
</summary>
393389
<pre
394390
class="pr-diff"
@@ -649,7 +645,7 @@ function updateOptionOutline() {
649645
: `https://echarts.apache.org/${lang}/option.html#${hash.join('.')}`;
650646
return !isObjOrArray
651647
? `<a href="${link}" target="_blank" title="${tipTitle}">${name}</a>`
652-
: `${name}<a href="${link}" target="_blank" title="${tipTitle}"><i class="el-icon-document"></i></a>`;
648+
: `${name}<a href="${link}" target="_blank" title="${tipTitle}"><i class="el-icon el-icon--right"><svg data-v-58697b5c="" xmlns="http://www.w3.org/2000/svg" viewBox="0 0 1024 1024"><path fill="currentColor" d="M832 384H576V128H192v768h640zm-26.496-64L640 154.496V320zM160 64h480l256 256v608a32 32 0 0 1-32 32H160a32 32 0 0 1-32-32V96a32 32 0 0 1 32-32m160 448h384v64H320zm0-192h160v64H320zm0 384h384v64H320z"></path></svg></i></a>`;
653649
},
654650
expandOnCreatedAndUpdated(path) {
655651
return path.length === 0 || (path[0] === 'series' && path.length <= 1);

‎src/editor/Preview.vue‎

Lines changed: 11 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -46,8 +46,10 @@
4646
<template #reference>
4747
<span class="render-config-trigger">
4848
<el-button size="small">
49-
{{ t('editor.renderCfgTitle')
50-
}}<i class="el-icon-setting el-icon--right"></i>
49+
{{ t('editor.renderCfgTitle') }}
50+
<el-icon class="el-icon--right">
51+
<Setting />
52+
</el-icon>
5153
</el-button>
5254
</span>
5355
</template>
@@ -108,27 +110,24 @@
108110
<div class="left-buttons">
109111
<template v-if="inEditor && !shared.isMobile">
110112
<el-button
111-
icon="el-icon-download"
112113
size="small"
113114
@click="downloadExample"
114115
:title="t('editor.download') + ' (HTML)'"
115116
>
116-
{{ t('editor.download') }}
117+
<el-icon><Download /></el-icon>
118+
<span>{{ t('editor.download') }}</span>
117119
</el-button>
118-
<el-button
119-
@click="screenshot"
120-
icon="el-icon-camera-solid"
121-
size="small"
122-
>
123-
{{ t('editor.screenshot') }}
120+
<el-button @click="screenshot" size="small">
121+
<el-icon><CameraFilled /></el-icon>
122+
<span>{{ t('editor.screenshot') }}</span>
124123
</el-button>
125124
<el-button
126125
@click="share"
127-
icon="el-icon-share"
128126
size="small"
129127
:title="t('editor.share.tooltip')"
130128
>
131-
{{ t('editor.share.title') }}
129+
<el-icon><Share /></el-icon>
130+
<span>{{ t('editor.share.title') }}</span>
132131
</el-button>
133132
</template>
134133
</div>

‎src/main.js‎

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -52,5 +52,10 @@ export function init(el, option) {
5252
const app = createApp(RootComponent);
5353
app.use(i18n);
5454
app.use(ElementPlus);
55+
if (typeof ElementPlusIconsVue !== 'undefined') {
56+
for (const [key, component] of Object.entries(ElementPlusIconsVue)) {
57+
app.component(key, component);
58+
}
59+
}
5560
app.mount(container);
5661
}

0 commit comments

Comments
 (0)