Skip to content

Commit 18c17b7

Browse files
committed
fix: code review
1 parent f6f7bdf commit 18c17b7

File tree

2 files changed

+10
-12
lines changed

2 files changed

+10
-12
lines changed

src/component/visualMap/VisualMapModel.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -261,7 +261,7 @@ class VisualMapModel<Opts extends VisualMapOption = VisualMapOption> extends Com
261261
if (seriesTargets) {
262262
// When seriesTargets is provided, collect all target series indices
263263
const indices: number[] = [];
264-
for (const target of seriesTargets) {
264+
each(seriesTargets, (target) => {
265265
if (target.seriesIndex != null) {
266266
indices.push(target.seriesIndex);
267267
}
@@ -277,7 +277,7 @@ class VisualMapModel<Opts extends VisualMapOption = VisualMapOption> extends Com
277277
indices.push(seriesModel.componentIndex);
278278
}
279279
}
280-
}
280+
});
281281
return indices;
282282
}
283283

src/component/visualMap/preprocessor.ts

Lines changed: 8 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -55,20 +55,18 @@ export default function visualMapPreprocessor(option) {
5555
}
5656

5757
// Validate seriesTargets
58-
const seriesTargets = opt.seriesTargets;
59-
if (seriesTargets && zrUtil.isArray(seriesTargets)) {
60-
each(seriesTargets, function (target) {
61-
if (!zrUtil.isObject(target) || target.dimension == null) {
62-
if (__DEV__) {
58+
if (__DEV__) {
59+
const seriesTargets = opt.seriesTargets;
60+
if (seriesTargets && zrUtil.isArray(seriesTargets)) {
61+
each(seriesTargets, function (target) {
62+
if (!zrUtil.isObject(target) || target.dimension == null) {
6363
console.warn('Each seriesTarget should have a dimension property');
6464
}
65-
}
66-
if (target.seriesIndex == null && target.seriesId == null) {
67-
if (__DEV__) {
65+
if (target.seriesIndex == null && target.seriesId == null) {
6866
console.warn('Each seriesTarget should have either seriesIndex or seriesId');
6967
}
70-
}
71-
});
68+
});
69+
}
7270
}
7371
});
7472
}

0 commit comments

Comments
 (0)