Skip to content

fix: Dump areaStyle polygon when notMerge is true #16772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 11, 2022
Merged

fix: Dump areaStyle polygon when notMerge is true #16772

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2fafe28
fix: Dump areaStyle polygon when notMerge is true
jiawulin001 Mar 30, 2022
f5c6ecd
Update for lint flaws
jiawulin001 Mar 30, 2022
d92ddba
test: tweak test case title and add VRT action.
plainheart Apr 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/chart/line/LineView.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -730,6 +730,10 @@ class LineView extends ChartView {
polygon = this._newPolygon(
points, stackedOnPoints
);
}// If areaStyle is removed
else if (polygon) {
lineGroup.remove(polygon);
polygon = this._polygon = null;
}

// NOTE: Must update _endLabel before setClipPath.
Expand Down
40 changes: 40 additions & 0 deletions test/setOption.html
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.