Skip to content

Commit 74daad3

Browse files
committed
fix: return immutable maps from DefaultConverterLoader
1 parent 3595c11 commit 74daad3

File tree

3 files changed

+8
-7
lines changed

3 files changed

+8
-7
lines changed

fesod/src/main/java/org/apache/fesod/sheet/converters/DefaultConverterLoader.java

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@
1919

2020
package org.apache.fesod.sheet.converters;
2121

22+
import java.util.Collections;
2223
import java.util.Map;
2324
import org.apache.fesod.sheet.converters.ConverterKeyBuild.ConverterKey;
2425
import org.apache.fesod.sheet.converters.bigdecimal.BigDecimalBooleanConverter;
@@ -175,10 +176,10 @@ private static void initDefaultWriteConverter() {
175176
/**
176177
* Load default write converter
177178
*
178-
* @return
179+
* @return Unmodifiable map of default write converters
179180
*/
180181
public static Map<ConverterKey, Converter<?>> loadDefaultWriteConverter() {
181-
return defaultWriteConverter;
182+
return Collections.unmodifiableMap(defaultWriteConverter);
182183
}
183184

184185
private static void putWriteConverter(Converter<?> converter) {
@@ -193,7 +194,7 @@ private static void putWriteStringConverter(Converter<?> converter) {
193194
/**
194195
* Load default read converter
195196
*
196-
* @return
197+
* @return Unmodifiable map of default read converters
197198
*/
198199
public static Map<ConverterKey, Converter<?>> loadDefaultReadConverter() {
199200
return loadAllConverter();
@@ -202,10 +203,10 @@ public static Map<ConverterKey, Converter<?>> loadDefaultReadConverter() {
202203
/**
203204
* Load all converter
204205
*
205-
* @return
206+
* @return Unmodifiable map of all converters
206207
*/
207208
public static Map<ConverterKey, Converter<?>> loadAllConverter() {
208-
return allConverter;
209+
return Collections.unmodifiableMap(allConverter);
209210
}
210211

211212
private static void putAllConverter(Converter<?> converter) {

fesod/src/main/java/org/apache/fesod/sheet/read/metadata/holder/AbstractReadHolder.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -114,7 +114,7 @@ public AbstractReadHolder(ReadBasicParameter readBasicParameter, AbstractReadHol
114114
}
115115

116116
if (parentAbstractReadHolder == null) {
117-
setConverterMap(DefaultConverterLoader.loadDefaultReadConverter());
117+
setConverterMap(new HashMap<>(DefaultConverterLoader.loadDefaultReadConverter()));
118118
} else {
119119
setConverterMap(new HashMap<>(parentAbstractReadHolder.getConverterMap()));
120120
}

fesod/src/main/java/org/apache/fesod/sheet/write/metadata/holder/AbstractWriteHolder.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -255,7 +255,7 @@ public AbstractWriteHolder(WriteBasicParameter writeBasicParameter, AbstractWrit
255255

256256
// Set converterMap
257257
if (parentAbstractWriteHolder == null) {
258-
setConverterMap(DefaultConverterLoader.loadDefaultWriteConverter());
258+
setConverterMap(new HashMap<>(DefaultConverterLoader.loadDefaultWriteConverter()));
259259
} else {
260260
setConverterMap(new HashMap<>(parentAbstractWriteHolder.getConverterMap()));
261261
}

0 commit comments

Comments
 (0)