Skip to content

Commit c2fdb1c

Browse files
authored
refactor: remove issue links and comments from code (#533)
1 parent 17eb760 commit c2fdb1c

File tree

13 files changed

+1
-25
lines changed

13 files changed

+1
-25
lines changed

fastexcel/src/main/java/cn/idev/excel/analysis/ExcelAnalyserImpl.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -219,7 +219,6 @@ public void finish() {
219219
}
220220

221221
// close csv.
222-
// https://github.com/fast-excel/fastexcel/issues/2309
223222
try {
224223
if ((readWorkbookHolder instanceof CsvReadWorkbookHolder)
225224
&& ((CsvReadWorkbookHolder) readWorkbookHolder).getCsvParser() != null

fastexcel/src/main/java/cn/idev/excel/analysis/v03/handlers/DummyRecordHandler.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,6 @@ public void processRecord(XlsReadContext xlsReadContext, Record record) {
3333
xlsReadSheetHolder.setTempRowType(RowTypeEnum.EMPTY);
3434
} else if (record instanceof MissingCellDummyRecord) {
3535
MissingCellDummyRecord mcdr = (MissingCellDummyRecord) record;
36-
// https://github.com/fast-excel/fastexcel/issues/2236
3736
// Some abnormal XLS, in the case of data already exist, or there will be a "MissingCellDummyRecord"
3837
// records, so if the existing data, empty data is ignored
3938
xlsReadSheetHolder

fastexcel/src/main/java/cn/idev/excel/read/listener/ModelBuildEventListener.java

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -73,9 +73,7 @@ private Object buildNoModel(
7373
}
7474
}
7575
}
76-
// fix https://github.com/fast-excel/fastexcel/issues/2014
7776
int headSize = calculateHeadSize(readSheetHolder);
78-
// fix https://github.com/fast-excel/fastexcel/issues/220
7977
while (index <= headSize) {
8078
map.put(index, null);
8179
index++;
@@ -178,7 +176,6 @@ private Object buildUserModel(
178176
dataMap.put(fieldName, value);
179177

180178
// 规避由于实体类 setter 不规范导致无法赋值的问题
181-
// fix https://github.com/alibaba/easyexcel/issues/3524
182179
if (dataMap.get(fieldName) == null) {
183180
Object bean = dataMap.getBean();
184181
try {

fastexcel/src/main/java/cn/idev/excel/read/metadata/holder/ReadSheetHolder.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,6 @@ public class ReadSheetHolder extends AbstractReadHolder {
6161
private ReadCellData<?> tempCellData;
6262
/**
6363
* Read the size of the largest head in sheet head data.
64-
* see https://github.com/fast-excel/fastexcel/issues/2014
6564
*/
6665
private Integer maxNotEmptyDataHeadSize;
6766

fastexcel/src/main/java/cn/idev/excel/util/BeanMapUtils.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@ public class BeanMapUtils {
1616
* <code>BeanMap.Generator</code> instead of this static method.
1717
*
1818
* Custom naming policy to prevent null pointer exceptions.
19-
* see: https://github.com/fast-excel/fastexcel/issues/2064
2019
*
2120
* @param bean the JavaBean underlying the map
2221
* @return a new <code>BeanMap</code> instance

fastexcel/src/main/java/cn/idev/excel/write/executor/ExcelWriteAddExecutor.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -102,7 +102,6 @@ private void addBasicTypeToExcel(RowData oneRowData, Row row, int rowIndex, int
102102
if (dataIndex >= oneRowData.size()) {
103103
return;
104104
}
105-
// fix https://github.com/fast-excel/fastexcel/issues/1702
106105
// If there is data, it is written to the next cell
107106
maxCellIndex++;
108107

@@ -220,7 +219,6 @@ private void addJavaObjectToExcel(Object oneRowData, Row row, int rowIndex, int
220219
excelContentProperty);
221220
WriteHandlerUtils.beforeCellCreate(cellWriteHandlerContext);
222221

223-
// fix https://github.com/fast-excel/fastexcel/issues/1870
224222
// If there is data, it is written to the next cell
225223
Cell cell = WorkBookUtil.createCell(row, maxCellIndex);
226224
cellWriteHandlerContext.setCell(cell);

fastexcel/src/main/java/cn/idev/excel/write/executor/ExcelWriteFillExecutor.java

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -452,7 +452,6 @@ private void checkRowHeight(AnalysisCell analysisCell, FillConfig fillConfig, bo
452452
if (!analysisCell.getFirstRow() || !WriteDirectionEnum.VERTICAL.equals(fillConfig.getDirection())) {
453453
return;
454454
}
455-
// fix https://github.com/fast-excel/fastexcel/issues/1869
456455
if (isOriginalCell && PoiUtils.customHeight(row)) {
457456
collectionRowHeightCache.put(currentUniqueDataFlag, row.getHeight());
458457
return;
@@ -562,7 +561,6 @@ private String prepareData(
562561
analysisCell.getVariableList().add(variable);
563562
if (lastPrepareDataIndex == prefixIndex) {
564563
analysisCell.getPrepareDataList().add(StringUtils.EMPTY);
565-
// fix https://github.com/fast-excel/fastexcel/issues/2035
566564
if (lastPrepareDataIndex != 0) {
567565
analysisCell.setOnlyOneVariable(Boolean.FALSE);
568566
}
@@ -574,7 +572,6 @@ private String prepareData(
574572
}
575573
lastPrepareDataIndex = suffixIndex + 1;
576574
}
577-
// fix https://github.com/fast-excel/fastexcel/issues/1552
578575
// When read template, XLSX data may be in `is` labels, and set the time set in `v` label, lead to can't set
579576
// up successfully, so all data format to empty first.
580577
if (analysisCell != null && CollectionUtils.isNotEmpty(analysisCell.getVariableList())) {

fastexcel/src/main/java/cn/idev/excel/write/handler/impl/DimensionWorkbookWriteHandler.java

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -16,10 +16,6 @@
1616

1717
/**
1818
* Handle the problem of unable to write dimension.
19-
*
20-
* https://github.com/fast-excel/fastexcel/issues/1282
21-
*
22-
*
2319
*/
2420
@Slf4j
2521
public class DimensionWorkbookWriteHandler implements WorkbookWriteHandler {

fastexcel/src/test/java/cn/idev/excel/test/core/compatibility/CompatibilityTest.java

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,6 @@ public class CompatibilityTest {
3030

3131
@Test
3232
public void t01() {
33-
// https://github.com/fast-excel/fastexcel/issues/2236
3433
List<Map<Integer, Object>> list = FastExcel.read(TestFileUtil.getPath() + "compatibility/t01.xls")
3534
.sheet()
3635
.doReadSync();
@@ -78,7 +77,6 @@ public void t04() {
7877

7978
@Test
8079
public void t05() {
81-
// https://github.com/fast-excel/fastexcel/issues/1956
8280
// Excel read date needs to be rounded
8381
List<Map<Integer, String>> list = FastExcel.read(TestFileUtil.getPath() + "compatibility/t05.xlsx")
8482
.sheet()
@@ -104,7 +102,6 @@ public void t06() {
104102

105103
@Test
106104
public void t07() {
107-
// https://github.com/fast-excel/fastexcel/issues/2805
108105
// Excel read date needs to be rounded
109106
List<Map<Integer, Object>> list = FastExcel.read(TestFileUtil.getPath() + "compatibility/t07.xlsx")
110107
.readDefaultReturn(ReadDefaultReturnEnum.ACTUAL_DATA)
@@ -123,7 +120,6 @@ public void t07() {
123120

124121
@Test
125122
public void t08() {
126-
// https://github.com/fast-excel/fastexcel/issues/2693
127123
// Temporary files may be deleted if there is no operation for a long time, so they need to be recreated.
128124
File file = TestFileUtil.createNewFile("compatibility/t08.xlsx");
129125
FastExcel.write(file, SimpleData.class).sheet().doWrite(data());

fastexcel/src/test/java/cn/idev/excel/test/demo/write/CustomCellWriteHandler.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
import org.apache.poi.ss.usermodel.Hyperlink;
1111

1212
/**
13-
* 自定义拦截器。对第一行第一列的头超链接到:https://github.com/fast-excel/fastexcel
13+
* 自定义拦截器
1414
*
1515
*
1616
*/

0 commit comments

Comments
 (0)