diff --git a/fastexcel/src/main/java/cn/idev/excel/analysis/ExcelAnalyserImpl.java b/fastexcel/src/main/java/cn/idev/excel/analysis/ExcelAnalyserImpl.java index 180b3b1a2..3a09a1875 100644 --- a/fastexcel/src/main/java/cn/idev/excel/analysis/ExcelAnalyserImpl.java +++ b/fastexcel/src/main/java/cn/idev/excel/analysis/ExcelAnalyserImpl.java @@ -219,7 +219,6 @@ public void finish() { } // close csv. - // https://github.com/fast-excel/fastexcel/issues/2309 try { if ((readWorkbookHolder instanceof CsvReadWorkbookHolder) && ((CsvReadWorkbookHolder) readWorkbookHolder).getCsvParser() != null diff --git a/fastexcel/src/main/java/cn/idev/excel/analysis/v03/handlers/DummyRecordHandler.java b/fastexcel/src/main/java/cn/idev/excel/analysis/v03/handlers/DummyRecordHandler.java index 234435e1d..b8280383a 100644 --- a/fastexcel/src/main/java/cn/idev/excel/analysis/v03/handlers/DummyRecordHandler.java +++ b/fastexcel/src/main/java/cn/idev/excel/analysis/v03/handlers/DummyRecordHandler.java @@ -33,7 +33,6 @@ public void processRecord(XlsReadContext xlsReadContext, Record record) { xlsReadSheetHolder.setTempRowType(RowTypeEnum.EMPTY); } else if (record instanceof MissingCellDummyRecord) { MissingCellDummyRecord mcdr = (MissingCellDummyRecord) record; - // https://github.com/fast-excel/fastexcel/issues/2236 // Some abnormal XLS, in the case of data already exist, or there will be a "MissingCellDummyRecord" // records, so if the existing data, empty data is ignored xlsReadSheetHolder diff --git a/fastexcel/src/main/java/cn/idev/excel/read/listener/ModelBuildEventListener.java b/fastexcel/src/main/java/cn/idev/excel/read/listener/ModelBuildEventListener.java index 88fe283d3..b316397b2 100644 --- a/fastexcel/src/main/java/cn/idev/excel/read/listener/ModelBuildEventListener.java +++ b/fastexcel/src/main/java/cn/idev/excel/read/listener/ModelBuildEventListener.java @@ -73,9 +73,7 @@ private Object buildNoModel( } } } - // fix https://github.com/fast-excel/fastexcel/issues/2014 int headSize = calculateHeadSize(readSheetHolder); - // fix https://github.com/fast-excel/fastexcel/issues/220 while (index <= headSize) { map.put(index, null); index++; @@ -178,7 +176,6 @@ private Object buildUserModel( dataMap.put(fieldName, value); // 规避由于实体类 setter 不规范导致无法赋值的问题 - // fix https://github.com/alibaba/easyexcel/issues/3524 if (dataMap.get(fieldName) == null) { Object bean = dataMap.getBean(); try { diff --git a/fastexcel/src/main/java/cn/idev/excel/read/metadata/holder/ReadSheetHolder.java b/fastexcel/src/main/java/cn/idev/excel/read/metadata/holder/ReadSheetHolder.java index 92817cb38..a8292b98a 100644 --- a/fastexcel/src/main/java/cn/idev/excel/read/metadata/holder/ReadSheetHolder.java +++ b/fastexcel/src/main/java/cn/idev/excel/read/metadata/holder/ReadSheetHolder.java @@ -61,7 +61,6 @@ public class ReadSheetHolder extends AbstractReadHolder { private ReadCellData tempCellData; /** * Read the size of the largest head in sheet head data. - * see https://github.com/fast-excel/fastexcel/issues/2014 */ private Integer maxNotEmptyDataHeadSize; diff --git a/fastexcel/src/main/java/cn/idev/excel/util/BeanMapUtils.java b/fastexcel/src/main/java/cn/idev/excel/util/BeanMapUtils.java index 7ef27f683..40ef35435 100644 --- a/fastexcel/src/main/java/cn/idev/excel/util/BeanMapUtils.java +++ b/fastexcel/src/main/java/cn/idev/excel/util/BeanMapUtils.java @@ -16,7 +16,6 @@ public class BeanMapUtils { * BeanMap.Generator instead of this static method. * * Custom naming policy to prevent null pointer exceptions. - * see: https://github.com/fast-excel/fastexcel/issues/2064 * * @param bean the JavaBean underlying the map * @return a new BeanMap instance diff --git a/fastexcel/src/main/java/cn/idev/excel/write/executor/ExcelWriteAddExecutor.java b/fastexcel/src/main/java/cn/idev/excel/write/executor/ExcelWriteAddExecutor.java index 05d146d66..f77adfe77 100644 --- a/fastexcel/src/main/java/cn/idev/excel/write/executor/ExcelWriteAddExecutor.java +++ b/fastexcel/src/main/java/cn/idev/excel/write/executor/ExcelWriteAddExecutor.java @@ -102,7 +102,6 @@ private void addBasicTypeToExcel(RowData oneRowData, Row row, int rowIndex, int if (dataIndex >= oneRowData.size()) { return; } - // fix https://github.com/fast-excel/fastexcel/issues/1702 // If there is data, it is written to the next cell maxCellIndex++; @@ -220,7 +219,6 @@ private void addJavaObjectToExcel(Object oneRowData, Row row, int rowIndex, int excelContentProperty); WriteHandlerUtils.beforeCellCreate(cellWriteHandlerContext); - // fix https://github.com/fast-excel/fastexcel/issues/1870 // If there is data, it is written to the next cell Cell cell = WorkBookUtil.createCell(row, maxCellIndex); cellWriteHandlerContext.setCell(cell); diff --git a/fastexcel/src/main/java/cn/idev/excel/write/executor/ExcelWriteFillExecutor.java b/fastexcel/src/main/java/cn/idev/excel/write/executor/ExcelWriteFillExecutor.java index 94c1ffd00..ef172f989 100644 --- a/fastexcel/src/main/java/cn/idev/excel/write/executor/ExcelWriteFillExecutor.java +++ b/fastexcel/src/main/java/cn/idev/excel/write/executor/ExcelWriteFillExecutor.java @@ -452,7 +452,6 @@ private void checkRowHeight(AnalysisCell analysisCell, FillConfig fillConfig, bo if (!analysisCell.getFirstRow() || !WriteDirectionEnum.VERTICAL.equals(fillConfig.getDirection())) { return; } - // fix https://github.com/fast-excel/fastexcel/issues/1869 if (isOriginalCell && PoiUtils.customHeight(row)) { collectionRowHeightCache.put(currentUniqueDataFlag, row.getHeight()); return; @@ -562,7 +561,6 @@ private String prepareData( analysisCell.getVariableList().add(variable); if (lastPrepareDataIndex == prefixIndex) { analysisCell.getPrepareDataList().add(StringUtils.EMPTY); - // fix https://github.com/fast-excel/fastexcel/issues/2035 if (lastPrepareDataIndex != 0) { analysisCell.setOnlyOneVariable(Boolean.FALSE); } @@ -574,7 +572,6 @@ private String prepareData( } lastPrepareDataIndex = suffixIndex + 1; } - // fix https://github.com/fast-excel/fastexcel/issues/1552 // When read template, XLSX data may be in `is` labels, and set the time set in `v` label, lead to can't set // up successfully, so all data format to empty first. if (analysisCell != null && CollectionUtils.isNotEmpty(analysisCell.getVariableList())) { diff --git a/fastexcel/src/main/java/cn/idev/excel/write/handler/impl/DimensionWorkbookWriteHandler.java b/fastexcel/src/main/java/cn/idev/excel/write/handler/impl/DimensionWorkbookWriteHandler.java index f96e48def..2a82645e3 100644 --- a/fastexcel/src/main/java/cn/idev/excel/write/handler/impl/DimensionWorkbookWriteHandler.java +++ b/fastexcel/src/main/java/cn/idev/excel/write/handler/impl/DimensionWorkbookWriteHandler.java @@ -16,10 +16,6 @@ /** * Handle the problem of unable to write dimension. - * - * https://github.com/fast-excel/fastexcel/issues/1282 - * - * */ @Slf4j public class DimensionWorkbookWriteHandler implements WorkbookWriteHandler { diff --git a/fastexcel/src/test/java/cn/idev/excel/test/core/compatibility/CompatibilityTest.java b/fastexcel/src/test/java/cn/idev/excel/test/core/compatibility/CompatibilityTest.java index 665a9b739..affded35f 100644 --- a/fastexcel/src/test/java/cn/idev/excel/test/core/compatibility/CompatibilityTest.java +++ b/fastexcel/src/test/java/cn/idev/excel/test/core/compatibility/CompatibilityTest.java @@ -30,7 +30,6 @@ public class CompatibilityTest { @Test public void t01() { - // https://github.com/fast-excel/fastexcel/issues/2236 List> list = FastExcel.read(TestFileUtil.getPath() + "compatibility/t01.xls") .sheet() .doReadSync(); @@ -78,7 +77,6 @@ public void t04() { @Test public void t05() { - // https://github.com/fast-excel/fastexcel/issues/1956 // Excel read date needs to be rounded List> list = FastExcel.read(TestFileUtil.getPath() + "compatibility/t05.xlsx") .sheet() @@ -104,7 +102,6 @@ public void t06() { @Test public void t07() { - // https://github.com/fast-excel/fastexcel/issues/2805 // Excel read date needs to be rounded List> list = FastExcel.read(TestFileUtil.getPath() + "compatibility/t07.xlsx") .readDefaultReturn(ReadDefaultReturnEnum.ACTUAL_DATA) @@ -123,7 +120,6 @@ public void t07() { @Test public void t08() { - // https://github.com/fast-excel/fastexcel/issues/2693 // Temporary files may be deleted if there is no operation for a long time, so they need to be recreated. File file = TestFileUtil.createNewFile("compatibility/t08.xlsx"); FastExcel.write(file, SimpleData.class).sheet().doWrite(data()); diff --git a/fastexcel/src/test/java/cn/idev/excel/test/demo/write/CustomCellWriteHandler.java b/fastexcel/src/test/java/cn/idev/excel/test/demo/write/CustomCellWriteHandler.java index 2e9670d1a..640403b31 100644 --- a/fastexcel/src/test/java/cn/idev/excel/test/demo/write/CustomCellWriteHandler.java +++ b/fastexcel/src/test/java/cn/idev/excel/test/demo/write/CustomCellWriteHandler.java @@ -10,7 +10,7 @@ import org.apache.poi.ss.usermodel.Hyperlink; /** - * 自定义拦截器。对第一行第一列的头超链接到:https://github.com/fast-excel/fastexcel + * 自定义拦截器 * * */ diff --git a/fastexcel/src/test/java/cn/idev/excel/test/temp/csv/CsvFormatTest.java b/fastexcel/src/test/java/cn/idev/excel/test/temp/csv/CsvFormatTest.java index bdb3be824..f5a7b64c0 100644 --- a/fastexcel/src/test/java/cn/idev/excel/test/temp/csv/CsvFormatTest.java +++ b/fastexcel/src/test/java/cn/idev/excel/test/temp/csv/CsvFormatTest.java @@ -151,7 +151,6 @@ public void testHolder() { excelWriter.write(csvDataList, writeSheet); } - // https://github.com/alibaba/FastExcel/issues/3868 csvFile = TestFileUtil.readFile(CSV_BASE + "csv-delimiter.csv"); try (ExcelReader excelReader = FastExcel.read(csvFile, CsvData.class, new CsvDataListener()).build()) { diff --git a/fastexcel/src/test/java/cn/idev/excel/test/temp/issue2319/Issue2319Test.java b/fastexcel/src/test/java/cn/idev/excel/test/temp/issue2319/Issue2319Test.java index cac296227..9e330f5d2 100644 --- a/fastexcel/src/test/java/cn/idev/excel/test/temp/issue2319/Issue2319Test.java +++ b/fastexcel/src/test/java/cn/idev/excel/test/temp/issue2319/Issue2319Test.java @@ -22,7 +22,6 @@ public void IssueTest1() { .doRead(); } - // CS304 (manually written) Issue link: https://github.com/alibaba/FastExcel/issues/2319 @Test public void IssueTest2() { String fileName = TestFileUtil.getPath() + "temp/issue2319" + File.separator + "test2.xlsx"; diff --git a/fastexcel/src/test/java/cn/idev/excel/test/temp/issue2443/Issue2443Test.java b/fastexcel/src/test/java/cn/idev/excel/test/temp/issue2443/Issue2443Test.java index fe52b4d6c..84a2ae231 100644 --- a/fastexcel/src/test/java/cn/idev/excel/test/temp/issue2443/Issue2443Test.java +++ b/fastexcel/src/test/java/cn/idev/excel/test/temp/issue2443/Issue2443Test.java @@ -14,7 +14,6 @@ @Slf4j public class Issue2443Test { - // CS304 (manually written) Issue link: https://github.com/fast-excel/fastexcel/issues/2443 @Test public void IssueTest1() { String fileName = TestFileUtil.getPath() + "temp/issue2443" + File.separator + "date1.xlsx"; @@ -27,7 +26,6 @@ public void IssueTest1() { .doRead(); } - // CS304 (manually written) Issue link: https://github.com/fast-excel/fastexcel/issues/2443 @Test public void IssueTest2() { String fileName = TestFileUtil.getPath() + "temp/issue2443" + File.separator + "date2.xlsx";