Skip to content

Commit 5468f79

Browse files
committed
FINERACT-2416: improve PR template
I started editing this just to fix the link to the "Pull Requests" doc (it moved from README.md to CONTRIBUTING.md), but then I saw a few other places in need of service. * use Markdown links for readability * add link to pull request size limit wiki page re: code dumps * remove link to PR 1284, it doesn't add anything here and takes the reader out of context * add link to mailing list * add link to testing docs
1 parent ef8621b commit 5468f79

File tree

1 file changed

+6
-8
lines changed

1 file changed

+6
-8
lines changed

.github/pull_request_template.md

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,18 +1,16 @@
11
## Description
22

3-
Describe the changes made and why they were made.
4-
5-
Ignore if these details are present on the associated [Apache Fineract JIRA ticket](https://github.com/apache/fineract/pull/1284).
3+
Describe the changes made and why they were made. (Ignore if these details are present on the associated Apache Fineract JIRA ticket.)
64

75
## Checklist
86

97
Please make sure these boxes are checked before submitting your pull request - thanks!
108

11-
- [ ] Write the commit message as per https://github.com/apache/fineract/#pull-requests
9+
- [ ] Write the commit message as per [our guidelines](https://github.com/apache/fineract/blob/develop/CONTRIBUTING.md#pull-requests)
1210
- [ ] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
13-
- [ ] Create/update unit or integration tests for verifying the changes made.
14-
- [ ] Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
11+
- [ ] Create/update [unit or integration tests](https://fineract.apache.org/docs/current/#_testing) for verifying the changes made.
12+
- [ ] Follow our [coding conventions](https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions).
1513
- [ ] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
16-
- [ ] Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)
14+
- [ ] [This PR must not be a "code dump"](https://cwiki.apache.org/confluence/display/FINERACT/Pull+Request+Size+Limit). Large changes can be made in a branch, with assistance. Ask for help on the [developer mailing list](https://fineract.apache.org/#contribute).
1715

18-
FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.
16+
Your assigned reviewer(s) will follow our [guidelines for code reviews](https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide).

0 commit comments

Comments
 (0)