Skip to content

Commit 8644d66

Browse files
FINERACT-2326: Fix configuration options for CORS (#5210)
1 parent a3fdfb9 commit 8644d66

File tree

5 files changed

+11
-11
lines changed

5 files changed

+11
-11
lines changed

fineract-core/src/main/java/org/apache/fineract/infrastructure/core/config/FineractProperties.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -695,7 +695,7 @@ public static class ExecuteCommandProperties {
695695
public static class CorsProperties {
696696

697697
private boolean enabled;
698-
private List<String> allowedOrigins;
698+
private List<String> allowedOriginPatterns;
699699
private List<String> allowedMethods;
700700
private List<String> allowedHeaders;
701701
private List<String> exposedHeaders;

fineract-provider/src/main/java/org/apache/fineract/infrastructure/core/config/SecurityConfig.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -263,7 +263,7 @@ public AuthenticationManager authenticationManagerBean() throws Exception {
263263
public CorsConfigurationSource corsConfigurationSource() {
264264
CorsConfiguration config = new CorsConfiguration();
265265
FineractProperties.CorsProperties corsConfiguration = fineractProperties.getSecurity().getCors();
266-
config.setAllowedOrigins(corsConfiguration.getAllowedOrigins());
266+
config.setAllowedOriginPatterns(corsConfiguration.getAllowedOriginPatterns());
267267
config.setAllowedMethods(corsConfiguration.getAllowedMethods());
268268
config.setAllowedHeaders(corsConfiguration.getAllowedHeaders());
269269
config.setExposedHeaders(corsConfiguration.getExposedHeaders());

fineract-provider/src/main/java/org/apache/fineract/infrastructure/security/config/AuthorizationServerConfig.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -192,7 +192,7 @@ public SecurityFilterChain protectedEndpoints(HttpSecurity http) throws Exceptio
192192
public CorsConfigurationSource corsConfigurationSource() {
193193
CorsConfiguration config = new CorsConfiguration();
194194
FineractProperties.CorsProperties corsConfiguration = fineractProperties.getSecurity().getCors();
195-
config.setAllowedOrigins(corsConfiguration.getAllowedOrigins());
195+
config.setAllowedOriginPatterns(corsConfiguration.getAllowedOriginPatterns());
196196
config.setAllowedMethods(corsConfiguration.getAllowedMethods());
197197
config.setAllowedHeaders(corsConfiguration.getAllowedHeaders());
198198
config.setExposedHeaders(corsConfiguration.getExposedHeaders());

fineract-provider/src/main/resources/application.properties

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -28,10 +28,10 @@ fineract.security.hsts.enabled=${FINERACT_SECURITY_HSTS_ENABLED:false}
2828

2929
#CORS configuration
3030
fineract.security.cors.enabled=${FINERACT_SECURITY_CORS_ENABLED:true}
31-
fineract.security.cors.allowed-origins=${FINERACT_SECURITY_CORS_ALLOWED_ORIGINS:"*"}
32-
fineract.security.cors.allowed-methods=${FINERACT_SECURITY_CORS_ALLOWED_METHODS:"*"}
33-
fineract.security.cors.allowed-headers=${FINERACT_SECURITY_CORS_ALLOWED_HEADERS:"*"}
34-
fineract.security.cors.exposed-headers=${FINERACT_SECURITY_CORS_EXPOSED_HEADERS:"*"}
31+
fineract.security.cors.allowed-origin-patterns=${FINERACT_SECURITY_CORS_ALLOWED_ORIGIN_PATTERNS:*}
32+
fineract.security.cors.allowed-methods=${FINERACT_SECURITY_CORS_ALLOWED_METHODS:*}
33+
fineract.security.cors.allowed-headers=${FINERACT_SECURITY_CORS_ALLOWED_HEADERS:*}
34+
fineract.security.cors.exposed-headers=${FINERACT_SECURITY_CORS_EXPOSED_HEADERS:*}
3535
fineract.security.cors.allow-credentials=${FINERACT_SECURITY_CORS_ALLOW_CREDENTIALS:true}
3636

3737
# EXAMPLE: OAuth2 client configuration (frontend-client)

fineract-provider/src/test/resources/application-test.properties

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -27,10 +27,10 @@ fineract.security.hsts.enabled=false
2727

2828
#CORS configuration
2929
fineract.security.cors.enabled=true
30-
fineract.security.cors.allowed-origins="*"
31-
fineract.security.cors.allowed-methods="*"
32-
fineract.security.cors.allowed-headers="*"
33-
fineract.security.cors.exposed-headers="*"
30+
fineract.security.cors.allowed-origin-patterns=*
31+
fineract.security.cors.allowed-methods=*
32+
fineract.security.cors.allowed-headers=*
33+
fineract.security.cors.exposed-headers=*
3434
fineract.security.cors.allow-credentials=true
3535

3636
fineract.tenant.host=localhost

0 commit comments

Comments
 (0)