FINERACT-2452: New command processing - audit

Co-Authored-By: Adam Saghy <adam.saghy@dpc.hu>
Co-Authored-By: Yu Wati Nyi <nyi22y@mtholyoke.edu>

Author: 3 people

config/docker/compose/fineract.yml

@@ -21,7 +21,7 @@ version: "3.8"
 services:
   fineract:
     # user: "${FINERACT_USER}:${FINERACT_GROUP}"
-    image: ${IMAGE_NAME:-apache/fineract:latest}
+    image: fineract:latest
     volumes:
       - ${PWD}/config/docker/logback/logback-override.xml:/app/logback-override.xml
       - ${PWD}/config/docker/aws/etc/credentials:/etc/aws/credentials:ro

config/docker/env/mariadb.env

@@ -0,0 +1,20 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
+
+MARIADB_ROOT_PASSWORD=mysql

docker-compose-community-app.yml

@@ -16,7 +16,6 @@
 # under the License.
 #
 
-version: "3.8"
 services:
   # Frontend service
   community-app:

docker-compose-custom.yml

@@ -17,7 +17,6 @@
 #
 
 # You can replace and test a more recent version of docker compose
-version: "3.8"
 services:
   db:
     extends:

docker-compose-development.yml

@@ -27,8 +27,6 @@ x-logging: &default-logging
       - regex:
           expression: '^(?P<date>\d{4}-\d{2}-\d{2}) (?P<time>\d{2}:\d{2}:\d{2}.\d{3}) (?P<message>(?s:.*))$$'
 
-version: "3.8"
-
 services:
   loki:
     extends:

docker-compose-mariadb.yml

@@ -0,0 +1,34 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
+
+services:
+  mariadb:
+    container_name: mariadb
+    image: mariadb:11.4
+    volumes:
+      - ./config/docker/mysql/conf.d/server_collation.cnf:/etc/mysql/conf.d/server_collation.cnf:ro
+      - ./config/docker/mysql/docker-entrypoint-initdb.d:/docker-entrypoint-initdb.d:Z,ro
+    restart: always
+    env_file:
+      - ./config/docker/env/mariadb.env
+    healthcheck:
+      test: [ "CMD", "healthcheck.sh", "--su-mysql", "--connect", "--innodb_initialized" ]
+      timeout: 10s
+      retries: 10
+    ports:
+      - "3306:3306"

docker-compose.yml

@@ -16,8 +16,6 @@
 # under the License.
 #
 
-version: "3.8"
-
 services:
 
   db:

fineract-cob/src/main/resources/jpa/static-weaving/module/fineract-cob/persistence.xml

@@ -66,10 +66,6 @@
         <class>org.apache.fineract.infrastructure.businessdate.domain.BusinessDate</class>
         <class>org.apache.fineract.infrastructure.codes.domain.CodeValue</class>
 
-        <!-- Command Module Entities -->
-        <class>org.apache.fineract.command.persistence.domain.CommandEntity</class>
-        <class>org.apache.fineract.command.persistence.converter.JsonAttributeConverter</class>
-
         <!-- Validation Module Entities -->
 
         <exclude-unlisted-classes>false</exclude-unlisted-classes>

fineract-command/README.md

@@ -89,15 +89,11 @@ These different perfromance level implementations need to be absolute drop-in re
 
 NOTE: we should consider providing a command processing implementation based on Apache Camel once this concept is approved and we migrated already a couple of services. They are specialized for exactly this kind of use cases and have more dedicated people working on it's implementation. Could give more flexibility without us needing to maintain code.
 
-3. Middlewares
+3. Command Handlers
 
 TBD
 
-4. Command Handlers
-
-TBD
-
-5. References to users (aka AppUser)
+4. References to users (aka AppUser)
 
 Keep things lightweight and only reference users by their user names.f
 

fineract-command/REFACTORING.md

@@ -52,7 +52,6 @@ Please make sure to always follow this package structure pattern:
 - `handler`: contains all command handlers
 - `service`: contains business logic services
 - `mapping`: contains MapStruct interfaces
-- `middleware`: contains middleware related to command processing; I am not expecting that we will need any of this during the refactoring process
 - `security`: might contain later so called Spring Security "authorization managers" for more complex use cases
 - `serialization`: technically we should not need this package anymore after we are done with the refactorings; in theory there could be very complex data structures that are not easily digestable by Jackson; for those case we could still use this package to add de-/serialization helpers (Jackson provides a proper API for this)
 - `starter`: Spring Java configuration that allows us to make Fineract customizable (make parts of the system replaceable)
@@ -237,7 +236,7 @@ Command Pipeline preserving Type Information
 public class DummyApiResource {
     ...
     @GET
-    DummyResponse dummy(@HeaderParam("x-fineract-request-id") UUID requestId, @HeaderParam("x-fineract-tenant-id") String tenantId, DummyRequest request) {
+    DummyResponse dummy(@HeaderParam("x-fineract-request-id") UUID requestId, @HeaderParam("Fineract-Platform-TenantId") String tenantId, DummyRequest request) {
         var command = new DummyCommand();
         command.setId(requestId);
         command.setPayload(request);