Skip to content

Commit cf11acf

Browse files
committed
FINERACT-2421: Fix GRETERTHAN typo in ConditionType enum
1 parent b7306f1 commit cf11acf

File tree

4 files changed

+7
-8
lines changed

4 files changed

+7
-8
lines changed

fineract-core/src/main/java/org/apache/fineract/portfolio/common/domain/ConditionType.java

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -25,8 +25,7 @@ public enum ConditionType {
2525
INVALID(0, "ConditionType.invalid"), //
2626
LESSTHAN(1, "ConditionType.lessthan"), //
2727
EQUAL(2, "ConditionType.equal"), //
28-
// TODO: fix typo "GREATERTHAN"
29-
GRETERTHAN(3, "ConditionType.greterthan"), //
28+
GREATERTHAN(3, "ConditionType.greaterthan"), //
3029
NOT_EQUAL(4, "ConditionType.notequal");//
3130

3231
private final Integer value;
@@ -43,7 +42,7 @@ public static ConditionType fromInt(final Integer v) {
4342
case 2:
4443
return EQUAL;
4544
case 3:
46-
return GRETERTHAN;
45+
return GREATERTHAN;
4746
case 4:
4847
return NOT_EQUAL;
4948
default:

fineract-core/src/main/java/org/apache/fineract/portfolio/common/service/CommonEnumerations.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -94,9 +94,9 @@ public static EnumOptionData conditionType(final ConditionType type, final Strin
9494
optionData = new EnumOptionData(ConditionType.NOT_EQUAL.getValue().longValue(),
9595
codePrefix + ConditionType.NOT_EQUAL.getCode(), "notEqual");
9696
break;
97-
case GRETERTHAN:
98-
optionData = new EnumOptionData(ConditionType.GRETERTHAN.getValue().longValue(),
99-
codePrefix + ConditionType.GRETERTHAN.getCode(), "greterthan");
97+
case GREATERTHAN:
98+
optionData = new EnumOptionData(ConditionType.GREATERTHAN.getValue().longValue(),
99+
codePrefix + ConditionType.GREATERTHAN.getCode(), "greaterthan");
100100
break;
101101
case LESSTHAN:
102102
optionData = new EnumOptionData(ConditionType.LESSTHAN.getValue().longValue(),

fineract-provider/src/main/java/org/apache/fineract/portfolio/common/service/DropdownReadPlatformServiceImpl.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ public List<EnumOptionData> retrievePeriodFrequencyTypeOptions() {
4545
@Override
4646
public List<EnumOptionData> retrieveConditionTypeOptions() {
4747
return Arrays.asList(conditionType(ConditionType.EQUAL, "condition"), conditionType(ConditionType.NOT_EQUAL, "condition"),
48-
conditionType(ConditionType.GRETERTHAN, "condition"), conditionType(ConditionType.LESSTHAN, "condition"));
48+
conditionType(ConditionType.GREATERTHAN, "condition"), conditionType(ConditionType.LESSTHAN, "condition"));
4949
}
5050

5151
@Override

fineract-savings/src/main/java/org/apache/fineract/portfolio/interestratechart/incentive/AttributeIncentiveCalculation.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ public boolean applyIncentive(ConditionType conditionType, Long attributeValue,
3838
case NOT_EQUAL:
3939
applyIncentive = compareVal != 0;
4040
break;
41-
case GRETERTHAN:
41+
case GREATERTHAN:
4242
applyIncentive = compareVal > 0;
4343
break;
4444
default:

0 commit comments

Comments
 (0)