Skip to content
This repository was archived by the owner on Feb 19, 2025. It is now read-only.

Commit 36b5bb3

Browse files
authored
Merge pull request #409 from UMD-ARLIS/feat/tabId
Feature: Adding tabId to log
2 parents 5ab92db + 8a54754 commit 36b5bb3

File tree

6 files changed

+27
-19
lines changed

6 files changed

+27
-19
lines changed

build/UserALEWebExtension/background.js

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -415,7 +415,7 @@ function createVersionParts(count) {
415415
* limitations under the License.
416416
*/
417417

418-
var browser$1 = detect();
418+
var browserInfo = detect();
419419
var logs$1;
420420
var config$1;
421421

@@ -706,8 +706,8 @@ function selectorizePath(path) {
706706
}
707707
function detectBrowser() {
708708
return {
709-
'browser': browser$1 ? browser$1.name : '',
710-
'version': browser$1 ? browser$1.version : ''
709+
'browser': browserInfo ? browserInfo.name : '',
710+
'version': browserInfo ? browserInfo.version : ''
711711
};
712712
}
713713

@@ -1143,11 +1143,15 @@ function dispatchTabMessage(message) {
11431143
});
11441144
});
11451145
}
1146-
browser.runtime.onMessage.addListener(function (message) {
1146+
browser.runtime.onMessage.addListener(function (message, sender, sendResponse) {
11471147
switch (message.type) {
11481148
// Handles logs rerouted from content and option scripts
11491149
case ADD_LOG:
1150-
log(message.payload);
1150+
var log$1 = message.payload;
1151+
if ("tab" in sender && "id" in sender.tab) {
1152+
log$1["tabId"] = sender.tab.id;
1153+
}
1154+
log(log$1);
11511155
break;
11521156
case CONFIG_CHANGE:
11531157
console.log(message);

build/UserALEWebExtension/content.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -405,7 +405,7 @@ function createVersionParts(count) {
405405
* limitations under the License.
406406
*/
407407

408-
var browser$1 = detect();
408+
var browserInfo = detect();
409409
var logs$1;
410410
var config$1;
411411

@@ -720,8 +720,8 @@ function selectorizePath(path) {
720720
}
721721
function detectBrowser() {
722722
return {
723-
'browser': browser$1 ? browser$1.name : '',
724-
'version': browser$1 ? browser$1.version : ''
723+
'browser': browserInfo ? browserInfo.name : '',
724+
'version': browserInfo ? browserInfo.version : ''
725725
};
726726
}
727727

build/UserALEWebExtension/options.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -405,7 +405,7 @@ function createVersionParts(count) {
405405
* limitations under the License.
406406
*/
407407

408-
var browser$1 = detect();
408+
var browserInfo = detect();
409409
var logs$1;
410410
var config$1;
411411

@@ -720,8 +720,8 @@ function selectorizePath(path) {
720720
}
721721
function detectBrowser() {
722722
return {
723-
'browser': browser$1 ? browser$1.name : '',
724-
'version': browser$1 ? browser$1.version : ''
723+
'browser': browserInfo ? browserInfo.name : '',
724+
'version': browserInfo ? browserInfo.version : ''
725725
};
726726
}
727727

build/userale-2.4.0.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -418,7 +418,7 @@
418418
* limitations under the License.
419419
*/
420420

421-
var browser = detect();
421+
var browserInfo = detect();
422422
var logs$1;
423423
var config$1;
424424

@@ -745,8 +745,8 @@
745745
}
746746
function detectBrowser() {
747747
return {
748-
'browser': browser ? browser.name : '',
749-
'version': browser ? browser.version : ''
748+
'browser': browserInfo ? browserInfo.name : '',
749+
'version': browserInfo ? browserInfo.version : ''
750750
};
751751
}
752752

src/UserALEWebExtension/background.js

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -44,11 +44,15 @@ function dispatchTabMessage(message) {
4444
});
4545
}
4646

47-
browser.runtime.onMessage.addListener(function (message) {
47+
browser.runtime.onMessage.addListener(function (message, sender, sendResponse) {
4848
switch (message.type) {
4949
// Handles logs rerouted from content and option scripts
5050
case MessageTypes.ADD_LOG:
51-
userale.log(message.payload);
51+
let log = message.payload;
52+
if("tab" in sender && "id" in sender.tab) {
53+
log["tabId"] = sender.tab.id;
54+
}
55+
userale.log(log);
5256
break;
5357

5458
case MessageTypes.CONFIG_CHANGE:

src/packageLogs.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
*/
1717

1818
import { detect } from 'detect-browser';
19-
const browser = detect();
19+
const browserInfo = detect();
2020

2121
export let logs;
2222
let config;
@@ -391,7 +391,7 @@ export function selectorizePath(path) {
391391

392392
export function detectBrowser() {
393393
return {
394-
'browser': browser ? browser.name : '',
395-
'version': browser ? browser.version : ''
394+
'browser': browserInfo ? browserInfo.name : '',
395+
'version': browserInfo ? browserInfo.version : ''
396396
};
397397
}

0 commit comments

Comments
 (0)