Skip to content

Commit 34a325e

Browse files
committed
fix: extract magic number into a named constant
Signed-off-by: yuxiqian <34335406+yuxiqian@users.noreply.github.com>
1 parent 2111f37 commit 34a325e

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-mysql/src/main/java/org/apache/flink/cdc/connectors/mysql/utils/MySqlTypeUtils.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -107,6 +107,7 @@ public class MySqlTypeUtils {
107107
private static final String MULTIPOLYGON = "MULTIPOLYGON";
108108
private static final String MULTILINESTRING = "MULTILINESTRING";
109109
private static final String UNKNOWN = "UNKNOWN";
110+
private static final int FLOAT_LENGTH_UNSPECIFIED_FLAG = -1;
110111

111112
/** Returns a corresponding Flink data type from a debezium {@link Column}. */
112113
public static DataType fromDbzColumn(Column column) {
@@ -164,7 +165,7 @@ private static DataType convertFromColumn(Column column) {
164165
case FLOAT:
165166
case FLOAT_UNSIGNED:
166167
case FLOAT_UNSIGNED_ZEROFILL:
167-
if (column.length() != -1) {
168+
if (column.length() != FLOAT_LENGTH_UNSPECIFIED_FLAG) {
168169
// For FLOAT types with length provided explicitly, treat it like DOUBLE
169170
return DataTypes.DOUBLE();
170171
} else {

0 commit comments

Comments
 (0)