Skip to content

Commit de37768

Browse files
committed
Optimize instanceof
1 parent ff66dfb commit de37768

File tree

1 file changed

+2
-3
lines changed

1 file changed

+2
-3
lines changed

flink-cdc-runtime/src/main/java/org/apache/flink/cdc/runtime/functions/SystemFunctionUtils.java

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -871,10 +871,9 @@ private static String castObjectIntoString(Object object) {
871871
private static int universalCompares(Object lhs, Object rhs) {
872872
Class<?> leftClass = lhs.getClass();
873873
Class<?> rightClass = rhs.getClass();
874-
if (leftClass.equals(rightClass) && Comparable.class.isAssignableFrom(leftClass)) {
874+
if (leftClass.equals(rightClass) && lhs instanceof Comparable) {
875875
return ((Comparable) lhs).compareTo(rhs);
876-
} else if (Number.class.isAssignableFrom(leftClass)
877-
&& Number.class.isAssignableFrom(rightClass)) {
876+
} else if (lhs instanceof Number && rhs instanceof Number) {
878877
return Double.compare(((Number) lhs).doubleValue(), ((Number) rhs).doubleValue());
879878
} else {
880879
throw new RuntimeException(

0 commit comments

Comments
 (0)