Skip to content

Commit 461f0f2

Browse files
committed
test fix
Signed-off-by: Attila Mészáros <[email protected]>
1 parent 40e8ca0 commit 461f0f2

File tree

2 files changed

+17
-5
lines changed

2 files changed

+17
-5
lines changed

flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/FlinkOperator.java

Lines changed: 12 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -91,6 +91,11 @@ public class FlinkOperator {
9191
private final Configuration baseConfig;
9292

9393
public FlinkOperator(@Nullable Configuration conf) {
94+
this(conf, null);
95+
}
96+
97+
@VisibleForTesting
98+
FlinkOperator(@Nullable Configuration conf, KubernetesClient client) {
9499
this.configManager =
95100
conf != null
96101
? new FlinkConfigManager(conf) // For testing only
@@ -100,9 +105,13 @@ public FlinkOperator(@Nullable Configuration conf) {
100105

101106
baseConfig = configManager.getDefaultConfig();
102107
this.metricGroup = OperatorMetricUtils.initOperatorMetrics(baseConfig);
103-
this.client =
104-
KubernetesClientUtils.getKubernetesClient(
105-
configManager.getOperatorConfiguration(), this.metricGroup);
108+
if (client == null) {
109+
this.client =
110+
KubernetesClientUtils.getKubernetesClient(
111+
configManager.getOperatorConfiguration(), this.metricGroup);
112+
} else {
113+
this.client = client;
114+
}
106115
this.operator = createOperator();
107116
this.validators = ValidatorUtils.discoverValidators(configManager);
108117
this.listeners = ListenerUtils.discoverListeners(configManager);

flink-kubernetes-operator/src/test/java/org/apache/flink/kubernetes/operator/FlinkOperatorTest.java

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@
2323

2424
import io.fabric8.kubeapitest.junit.EnableKubeAPIServer;
2525
import io.fabric8.kubernetes.client.Config;
26+
import io.fabric8.kubernetes.client.KubernetesClient;
2627
import io.javaoperatorsdk.operator.RegisteredController;
2728
import io.javaoperatorsdk.operator.api.config.ControllerConfiguration;
2829
import io.javaoperatorsdk.operator.processing.event.rate.LinearRateLimiter;
@@ -39,9 +40,11 @@
3940
* ConfigurationServiceProvider) we write multiple tests as a single function, please provide
4041
* ample comments.
4142
*/
42-
@EnableKubeAPIServer(updateKubeConfigFile = true)
43+
@EnableKubeAPIServer
4344
class FlinkOperatorTest {
4445

46+
static KubernetesClient kubernetesClient;
47+
4548
@Test
4649
void testConfigurationPassedToJOSDK() {
4750
var testParallelism = 42;
@@ -61,7 +64,7 @@ void testConfigurationPassedToJOSDK() {
6164
operatorConfig.set(
6265
KubernetesOperatorConfigOptions.OPERATOR_LEADER_ELECTION_LEASE_NAME, testLeaseName);
6366

64-
var testOperator = new FlinkOperator(operatorConfig);
67+
var testOperator = new FlinkOperator(operatorConfig, kubernetesClient);
6568
testOperator.registerDeploymentController();
6669
testOperator.registerSessionJobController();
6770

0 commit comments

Comments
 (0)