Skip to content

Commit 4f4c39f

Browse files
committed
Clean up
1 parent 4834517 commit 4f4c39f

File tree

1 file changed

+3
-6
lines changed

1 file changed

+3
-6
lines changed

flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/controller/FlinkBlueGreenDeploymentController.java

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -207,7 +207,7 @@ private UpdateControl<FlinkBlueGreenDeployment> monitorTransition(
207207
+ ", current deployment type: "
208208
+ currentDeploymentType);
209209

210-
if (isDeploymentReady(nextDeployment, josdkContext, deploymentStatus)) {
210+
if (isDeploymentReady(nextDeployment)) {
211211
return canDelete(
212212
bgDeployment, deploymentStatus, josdkContext, currentDeployment, nextState);
213213
} else {
@@ -366,7 +366,7 @@ private UpdateControl<FlinkBlueGreenDeployment> checkAndInitiateDeployment(
366366
? deployments.getFlinkDeploymentBlue()
367367
: deployments.getFlinkDeploymentGreen();
368368

369-
if (isDeploymentReady(currentFlinkDeployment, josdkContext, deploymentStatus)) {
369+
if (isDeploymentReady(currentFlinkDeployment)) {
370370

371371
DeploymentType nextDeploymentType = DeploymentType.BLUE;
372372
FlinkBlueGreenDeploymentState nextState =
@@ -455,10 +455,7 @@ private UpdateControl<FlinkBlueGreenDeployment> initiateDeployment(
455455
.rescheduleAfter(getReconciliationReschedInterval(bgDeployment));
456456
}
457457

458-
private boolean isDeploymentReady(
459-
FlinkDeployment deployment,
460-
Context<FlinkBlueGreenDeployment> josdkContext,
461-
FlinkBlueGreenDeploymentStatus deploymentStatus) {
458+
private boolean isDeploymentReady(FlinkDeployment deployment) {
462459
return ResourceLifecycleState.STABLE == deployment.getStatus().getLifecycleState()
463460
&& JobStatus.RUNNING == deployment.getStatus().getJobStatus().getState();
464461
}

0 commit comments

Comments
 (0)