Skip to content

Commit 7175b2b

Browse files
author
nishita-pattanayak
committed
[FLINK-28648][Flink-Kubernetes-Operator] Cleanup Comments
1 parent 07d5c1a commit 7175b2b

File tree

1 file changed

+3
-5
lines changed

1 file changed

+3
-5
lines changed

flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/reconciler/deployment/SessionReconciler.java

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -127,10 +127,7 @@ private void recoverSession(FlinkResourceContext<FlinkDeployment> ctx) throws Ex
127127
.setJobManagerDeploymentStatus(JobManagerDeploymentStatus.DEPLOYING);
128128
}
129129

130-
/**
131-
* Detects unmanaged jobs running in the session cluster. Unmanaged jobs are jobs that exist in
132-
* the Flink cluster but are not managed by FlinkSessionJob resources.
133-
*/
130+
// Detects jobs which are not in globally terminated states
134131
@VisibleForTesting
135132
Set<JobID> getNonTerminalJobs(FlinkResourceContext<FlinkDeployment> ctx) {
136133
LOG.debug("Starting nonTerminal jobs detection for session cluster");
@@ -186,7 +183,8 @@ public DeleteControl cleanupInternal(FlinkResourceContext<FlinkDeployment> ctx)
186183
.rescheduleAfter(ctx.getOperatorConfig().getReconcileInterval().toMillis());
187184
}
188185

189-
// Check for unmanaged non-terminated jobs if the option is enabled (Enabled by default)
186+
// Check for non-terminated jobs if the option is enabled (Enabled by default) , after
187+
// sessionJobs are deleted
190188
boolean blockOnUnmanagedJobs =
191189
ctx.getObserveConfig()
192190
.getBoolean(KubernetesOperatorConfigOptions.BLOCK_ON_UNMANAGED_JOBS);

0 commit comments

Comments
 (0)