Skip to content

Commit 7f3498c

Browse files
committed
wip
Signed-off-by: Attila Mészáros <[email protected]>
1 parent d59dde5 commit 7f3498c

File tree

3 files changed

+11
-9
lines changed

3 files changed

+11
-9
lines changed

flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/utils/IngressUtils.java

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,6 +48,7 @@
4848
import java.util.Collections;
4949
import java.util.HashMap;
5050
import java.util.List;
51+
import java.util.Map;
5152
import java.util.Optional;
5253
import java.util.regex.Pattern;
5354
import java.util.stream.Collectors;
@@ -102,7 +103,10 @@ private static HasMetadata getIngress(
102103
FlinkDeploymentSpec spec,
103104
Configuration effectiveConfig,
104105
KubernetesClient client) {
105-
var labels = new HashMap<>(spec.getIngress().getLabels());
106+
Map<String, String> labels =
107+
spec.getIngress().getLabels() == null
108+
? new HashMap<>()
109+
: new HashMap<>(spec.getIngress().getLabels());
106110
labels.put(Constants.LABEL_COMPONENT_KEY, LABEL_COMPONENT_INGRESS);
107111
if (ingressInNetworkingV1(client)) {
108112
return new IngressBuilder()

flink-kubernetes-operator/src/test/java/org/apache/flink/kubernetes/operator/FlinkOperatorTest.java

Lines changed: 5 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -21,12 +21,12 @@
2121
import org.apache.flink.configuration.IllegalConfigurationException;
2222
import org.apache.flink.kubernetes.operator.config.KubernetesOperatorConfigOptions;
2323

24+
import io.fabric8.kubeapitest.junit.EnableKubeAPIServer;
2425
import io.fabric8.kubernetes.client.Config;
2526
import io.javaoperatorsdk.operator.RegisteredController;
2627
import io.javaoperatorsdk.operator.api.config.ControllerConfiguration;
2728
import io.javaoperatorsdk.operator.processing.event.rate.LinearRateLimiter;
2829
import org.junit.jupiter.api.Assertions;
29-
import org.junit.jupiter.api.BeforeAll;
3030
import org.junit.jupiter.api.Test;
3131

3232
import java.util.concurrent.ThreadPoolExecutor;
@@ -39,14 +39,11 @@
3939
* ConfigurationServiceProvider) we write multiple tests as a single function, please provide
4040
* ample comments.
4141
*/
42-
public class FlinkOperatorTest {
43-
@BeforeAll
44-
public static void setAutoTryKubeConfig() {
45-
System.setProperty(Config.KUBERNETES_AUTH_TRYKUBECONFIG_SYSTEM_PROPERTY, "false");
46-
}
42+
@EnableKubeAPIServer(updateKubeConfigFile = true)
43+
class FlinkOperatorTest {
4744

4845
@Test
49-
public void testConfigurationPassedToJOSDK() {
46+
void testConfigurationPassedToJOSDK() {
5047
var testParallelism = 42;
5148
var testSelector = "flink=enabled";
5249
var testLeaseName = "test-lease";
@@ -99,7 +96,7 @@ public void testConfigurationPassedToJOSDK() {
9996
}
10097

10198
@Test
102-
public void testLeaderElectionConfig() {
99+
void testLeaderElectionConfig() {
103100
var operatorConfig = new Configuration();
104101
operatorConfig.set(KubernetesOperatorConfigOptions.OPERATOR_LEADER_ELECTION_ENABLED, true);
105102

flink-kubernetes-operator/src/test/java/org/apache/flink/kubernetes/operator/controller/FlinkDeploymentControllerTest.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -934,6 +934,7 @@ public void cleanUpNewDeployment() {
934934
assertTrue(testController.getContextFactory().getMetricGroups().isEmpty());
935935
}
936936

937+
// todo add test here
937938
@Test
938939
public void testIngressLifeCycle() throws Exception {
939940
FlinkDeployment appNoIngress = TestUtils.buildApplicationCluster();

0 commit comments

Comments
 (0)