Skip to content

Commit 8c45e14

Browse files
committed
[FLINK-37730][Exception] Beautify Exception reporting in events
1 parent 7414fc4 commit 8c45e14

File tree

1 file changed

+2
-8
lines changed

1 file changed

+2
-8
lines changed

flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/observer/JobStatusObserver.java

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -176,7 +176,7 @@ protected void observeJobManagerExceptions(FlinkResourceContext<R> ctx) {
176176
break;
177177
}
178178
emitJobManagerExceptionEvent(ctx, exception, exceptionTime, maxStackTraceLines);
179-
if (latestSeen == null || exceptionTime.isAfter(latestSeen)) {
179+
if (latestSeen == null) {
180180
latestSeen = exceptionTime;
181181
}
182182
if (++count >= maxEvents) {
@@ -201,11 +201,6 @@ private void emitJobManagerExceptionEvent(
201201
JobExceptionsInfoWithHistory.RootExceptionInfo exception,
202202
Instant exceptionTime,
203203
int maxStackTraceLines) {
204-
205-
String exceptionName = exception.getExceptionName();
206-
if (exceptionName == null || exceptionName.isBlank()) {
207-
return;
208-
}
209204
Map<String, String> annotations = new HashMap<>();
210205
if (exceptionTime != null) {
211206
annotations.put(
@@ -227,11 +222,10 @@ private void emitJobManagerExceptionEvent(
227222
.forEach((k, v) -> annotations.put("failure-label-" + k, v));
228223
}
229224

230-
StringBuilder eventMessage = new StringBuilder(exceptionName);
225+
StringBuilder eventMessage = new StringBuilder();
231226
String stacktrace = exception.getStacktrace();
232227
if (stacktrace != null && !stacktrace.isBlank()) {
233228
String[] lines = stacktrace.split("\n");
234-
eventMessage.append("\n\nStacktrace (truncated):\n");
235229
for (int i = 0; i < Math.min(maxStackTraceLines, lines.length); i++) {
236230
eventMessage.append(lines[i]).append("\n");
237231
}

0 commit comments

Comments
 (0)