Skip to content

Commit 93e68f2

Browse files
committed
[FLINK-37571] Fix JobGraph removal for 2.0 last-state upgrades
1 parent 7a65e02 commit 93e68f2

File tree

2 files changed

+8
-5
lines changed

2 files changed

+8
-5
lines changed

flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/utils/FlinkUtils.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -335,7 +335,8 @@ private static boolean checkpointExists(ConfigMap cm) {
335335
}
336336

337337
private static boolean isJobGraphKey(Map.Entry<String, String> entry) {
338-
return entry.getKey().startsWith(Constants.JOB_GRAPH_STORE_KEY_PREFIX);
338+
return entry.getKey().startsWith(Constants.JOB_GRAPH_STORE_KEY_PREFIX)
339+
|| entry.getKey().startsWith("executionPlan-");
339340
}
340341

341342
public static boolean isZookeeperHAActivated(Configuration configuration) {

flink-kubernetes-operator/src/test/java/org/apache/flink/kubernetes/operator/utils/FlinkUtilsTest.java

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@
1818

1919
package org.apache.flink.kubernetes.operator.utils;
2020

21-
import org.apache.flink.api.common.JobID;
2221
import org.apache.flink.configuration.Configuration;
2322
import org.apache.flink.configuration.CoreOptions;
2423
import org.apache.flink.configuration.HighAvailabilityOptions;
@@ -51,6 +50,8 @@
5150
import io.fabric8.kubernetes.client.server.mock.KubernetesMockServer;
5251
import io.javaoperatorsdk.operator.processing.event.ResourceID;
5352
import org.junit.jupiter.api.Test;
53+
import org.junit.jupiter.params.ParameterizedTest;
54+
import org.junit.jupiter.params.provider.ValueSource;
5455

5556
import java.net.HttpURLConnection;
5657
import java.util.Collections;
@@ -125,12 +126,13 @@ public void testAddStartupProbe() {
125126
assertEquals(expectedProbe, pod.getSpec().getContainers().get(1).getStartupProbe());
126127
}
127128

128-
@Test
129-
public void testDeleteJobGraphInKubernetesHA() {
129+
@ParameterizedTest
130+
@ValueSource(strings = {"jobGraph-jobId", "executionPlan-jobId"})
131+
public void testDeleteJobGraphInKubernetesHA(String key) {
130132
final String name = "ha-configmap";
131133
final String clusterId = "cluster-id";
132134
final Map<String, String> data = new HashMap<>();
133-
data.put(Constants.JOB_GRAPH_STORE_KEY_PREFIX + JobID.generate(), "job-graph-data");
135+
data.put(key, "job-graph-data");
134136
data.put("leader", "localhost");
135137
createHAConfigMapWithData(name, kubernetesClient.getNamespace(), clusterId, data);
136138
assertNotNull(kubernetesClient.configMaps().withName(name).get());

0 commit comments

Comments
 (0)