Skip to content

Commit 980386d

Browse files
committed
Address Max and yuanfeng's comments
1 parent 3a3c045 commit 980386d

File tree

2 files changed

+9
-9
lines changed

2 files changed

+9
-9
lines changed

flink-autoscaler/src/main/java/org/apache/flink/autoscaler/DelayedScaleDown.java

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -64,19 +64,19 @@ public DelayedScaleDown() {
6464
@Nonnull
6565
public VertexDelayedScaleDownInfo triggerScaleDown(
6666
JobVertexID vertex, Instant triggerTime, int parallelism) {
67-
var vertexInfo = delayedVertices.get(vertex);
68-
if (vertexInfo == null) {
67+
var vertexDelayedScaleDownInfo = delayedVertices.get(vertex);
68+
if (vertexDelayedScaleDownInfo == null) {
6969
// It's the first trigger
70-
vertexInfo = new VertexDelayedScaleDownInfo(triggerTime, parallelism);
71-
delayedVertices.put(vertex, vertexInfo);
70+
vertexDelayedScaleDownInfo = new VertexDelayedScaleDownInfo(triggerTime, parallelism);
71+
delayedVertices.put(vertex, vertexDelayedScaleDownInfo);
7272
updated = true;
73-
} else if (parallelism > vertexInfo.getMaxRecommendedParallelism()) {
73+
} else if (parallelism > vertexDelayedScaleDownInfo.getMaxRecommendedParallelism()) {
7474
// Not the first trigger, but the maxRecommendedParallelism needs to be updated.
75-
vertexInfo.setMaxRecommendedParallelism(parallelism);
75+
vertexDelayedScaleDownInfo.setMaxRecommendedParallelism(parallelism);
7676
updated = true;
7777
}
7878

79-
return vertexInfo;
79+
return vertexDelayedScaleDownInfo;
8080
}
8181

8282
// Clear the delayed scale down for corresponding vertex when the recommended parallelism is

flink-autoscaler/src/main/java/org/apache/flink/autoscaler/ScalingExecutor.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -181,12 +181,12 @@ private void updateRecommendedParallelism(
181181
static boolean allChangedVerticesWithinUtilizationTarget(
182182
Map<JobVertexID, Map<ScalingMetric, EvaluatedScalingMetric>> evaluatedMetrics,
183183
Set<JobVertexID> changedVertices) {
184-
// No any vertex is changed.
184+
// No vertices with changed parallelism.
185185
if (changedVertices.isEmpty()) {
186186
return true;
187187
}
188188

189-
for (var vertex : changedVertices) {
189+
for (JobVertexID vertex : changedVertices) {
190190
var metrics = evaluatedMetrics.get(vertex);
191191

192192
double trueProcessingRate = metrics.get(TRUE_PROCESSING_RATE).getAverage();

0 commit comments

Comments
 (0)