Skip to content

Commit a024636

Browse files
author
chenyuzhi
committed
[FLINK-36264]: remove applyIngressDomain
1 parent 9d9d42c commit a024636

File tree

2 files changed

+0
-36
lines changed

2 files changed

+0
-36
lines changed

flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/config/FlinkConfigBuilder.java

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -241,17 +241,6 @@ protected FlinkConfigBuilder applyPodTemplate() throws IOException {
241241
return this;
242242
}
243243

244-
protected FlinkConfigBuilder applyIngressDomain() {
245-
// Web UI
246-
if (spec.getIngress() != null
247-
&& effectiveConfig.getOptional(REST_SERVICE_EXPOSED_TYPE).isEmpty()) {
248-
effectiveConfig.set(
249-
REST_SERVICE_EXPOSED_TYPE,
250-
KubernetesConfigOptions.ServiceExposedType.ClusterIP);
251-
}
252-
return this;
253-
}
254-
255244
protected FlinkConfigBuilder applyServiceAccount() {
256245
if (spec.getServiceAccount() != null) {
257246
effectiveConfig.set(
@@ -416,7 +405,6 @@ public static Configuration buildFrom(
416405
.applyImagePullPolicy()
417406
.applyServiceAccount()
418407
.applyPodTemplate()
419-
.applyIngressDomain()
420408
.applyJobManagerSpec()
421409
.applyTaskManagerSpec()
422410
.applyJobOrSessionSpec()

flink-kubernetes-operator/src/test/java/org/apache/flink/kubernetes/operator/config/FlinkConfigBuilderTest.java

Lines changed: 0 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -382,30 +382,6 @@ private PodTemplateSpec getTmPod(Configuration configuration) throws IOException
382382
PodTemplateSpec.class);
383383
}
384384

385-
@ParameterizedTest
386-
@MethodSource("serviceExposedTypes")
387-
public void testApplyIngressDomain(
388-
KubernetesConfigOptions.ServiceExposedType serviceExposedType) {
389-
390-
final Configuration configuration =
391-
new FlinkConfigBuilder(
392-
flinkDeployment,
393-
serviceExposedType == null
394-
? new Configuration()
395-
: new Configuration()
396-
.set(
397-
KubernetesConfigOptions
398-
.REST_SERVICE_EXPOSED_TYPE,
399-
serviceExposedType))
400-
.applyIngressDomain()
401-
.build();
402-
assertEquals(
403-
serviceExposedType == null
404-
? KubernetesConfigOptions.ServiceExposedType.ClusterIP
405-
: serviceExposedType,
406-
configuration.get(KubernetesConfigOptions.REST_SERVICE_EXPOSED_TYPE));
407-
}
408-
409385
@Test
410386
public void testApplyServiceAccount() {
411387
final Configuration configuration =

0 commit comments

Comments
 (0)