Skip to content

Commit c8d9b62

Browse files
committed
[FLINK-36473] better comparison for doubles
1 parent 5256ad3 commit c8d9b62

File tree

1 file changed

+7
-3
lines changed

1 file changed

+7
-3
lines changed

flink-kubernetes-operator/src/test/java/org/apache/flink/kubernetes/operator/metrics/KubernetesClientMetricsTest.java

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -52,6 +52,7 @@
5252
import static org.apache.flink.kubernetes.operator.metrics.KubernetesClientMetrics.KUBE_CLIENT_GROUP;
5353
import static org.apache.flink.kubernetes.operator.metrics.KubernetesClientMetrics.METER;
5454
import static org.assertj.core.api.Assertions.assertThat;
55+
import static org.assertj.core.api.Assertions.byLessThan;
5556
import static org.assertj.core.api.InstanceOfAssertFactories.LONG;
5657
import static org.awaitility.Awaitility.await;
5758
import static org.junit.jupiter.api.Assertions.assertFalse;
@@ -356,17 +357,20 @@ void testAPIServerIsDown() {
356357
}
357358

358359
private static void assertRateIsZero(TestingMetricListener listener, String meterId) {
359-
assertPositiveRate(listener, meterId, meter -> assertThat(meter.getRate()).isEqualTo(0.0));
360+
assertRate(
361+
listener,
362+
meterId,
363+
meter -> assertThat(meter.getRate()).isCloseTo(0.0, byLessThan(0.00001)));
360364
}
361365

362366
private static void assertPositiveRate(TestingMetricListener listener, String meterId) {
363-
assertPositiveRate(
367+
assertRate(
364368
listener,
365369
meterId,
366370
meter -> assertThat(meter.getRate()).isGreaterThanOrEqualTo(0.01));
367371
}
368372

369-
private static void assertPositiveRate(
373+
private static void assertRate(
370374
TestingMetricListener listener, String meterId, Consumer<Meter> meterConsumer) {
371375
assertThat(listener.getMeter(listener.getMetricId(meterId)))
372376
.hasValueSatisfying(meterConsumer);

0 commit comments

Comments
 (0)