[FLINK-36392] Build with target jdk #888
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SamBarker
force-pushed
the
build-with-target-jdk
branch
from
e5fb53d to
765d7ac
Compare
Avoids duplicated execution when updating a PR.
SamBarker
force-pushed
the
build-with-target-jdk
branch
from
8197362 to
20e7fad
Compare
SamBarker
commented
Oct 7, 2024
Comment on lines
+26
to
+28
| branches: | ||
| - main | ||
| - release-* |
Contributor
Author
There was a problem hiding this comment.
Not strictly needed for this PR, but reduces the number of build jobs to wade through (especially useful when debugging). Happy to drop/move to a new PR if desired.
| # Build | ||
| FROM maven:3.8.4-eclipse-temurin-11 AS build | ||
| ARG JAVA_VERSION=11 | ||
| FROM maven:3.8.8-eclipse-temurin-${JAVA_VERSION} AS build |
Contributor
Author
There was a problem hiding this comment.
Bumps the maven version. I went for the oldest version which supports all three of the desired java versions. Could equally jump to the latest maven version (3.9.9 IIRC).
This is the core of the fix so that maven in the docker container actually builds with the desired JVM version.
gyfora
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Fixes the docker build for edge to edge (e2e) ci tests so that they build the operator with the Java version specified by the test matrix.
Brief change log
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:
CustomResourceDescriptors: noDocumentation