Skip to content

Commit 1e868c8

Browse files
MartijnVisserclaude
andcommitted
[FLINK-39017][web] Fix task click handler in job graph for Chrome 144+
Chrome 144 introduced BoundaryEventDispatchTracksNodeRemoval which changes how pointer/mouse boundary events are dispatched after DOM mutations. The onNodeMouseEnter handler used appendChild to reorder SVG elements for z-ordering, which caused Chrome to reset the logical pointer target to the parent graph element. This prevented click events from reaching the node-group elements. Remove appendChild DOM mutations from onNodeMouseEnter and onNodeMouseLeave. Link focus styling on hover is preserved via property changes without DOM reordering. Co-Authored-By: Claude Opus 4.6 <[email protected]> (cherry picked from commit f5e7558)
1 parent ea843de commit 1e868c8

File tree

1 file changed

+0
-15
lines changed

1 file changed

+0
-15
lines changed

flink-runtime-web/web-dashboard/src/app/components/dagre/dagre.component.ts

Lines changed: 0 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -359,7 +359,6 @@ export class DagreComponent extends NzGraph {
359359
* @param $event
360360
*/
361361
onNodeMouseEnter($event: MouseEvent): void {
362-
this.graphElement.nativeElement.appendChild($event.target);
363362
this.layoutLinks.forEach(l => {
364363
if (l.id.split('-').indexOf(($event.target as HTMLElement).id) !== -1) {
365364
l.options.focused = true;
@@ -376,20 +375,6 @@ export class DagreComponent extends NzGraph {
376375
l.options.focused = this.focusedLinkIds.indexOf(l.id) !== -1;
377376
});
378377

379-
this.graphElement.nativeElement.appendChild(this.overlayElement.nativeElement);
380-
381-
this.graphElement.nativeElement.querySelectorAll(`.link-group`).forEach((e: Element) => {
382-
if (this.focusedLinkIds.indexOf(e.id) !== -1) {
383-
this.graphElement.nativeElement.appendChild(e);
384-
}
385-
});
386-
387-
this.graphElement.nativeElement.querySelectorAll(`.node-group`).forEach((e: Element) => {
388-
if ([this.selectedNodeId, ...this.circleNodeIds].indexOf(e.id) !== -1) {
389-
this.graphElement.nativeElement.appendChild(e);
390-
}
391-
});
392-
393378
this.cd.detectChanges();
394379
}
395380

0 commit comments

Comments
 (0)