Skip to content

Commit cbfd996

Browse files
MartijnVisserclaude
andcommitted
[FLINK-39017][web] Fix task click handler in job graph for Chrome 144+
Chrome 144 introduced BoundaryEventDispatchTracksNodeRemoval which changes how pointer/mouse boundary events are dispatched after DOM mutations. The onNodeMouseEnter handler used appendChild to reorder SVG elements for z-ordering, which caused Chrome to reset the logical pointer target to the parent graph element. This prevented click events from reaching the node-group elements. Remove appendChild DOM mutations from onNodeMouseEnter and onNodeMouseLeave. Link focus styling on hover is preserved via property changes without DOM reordering. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> (cherry picked from commit f5e7558)
1 parent 98dce2f commit cbfd996

File tree

1 file changed

+0
-15
lines changed

1 file changed

+0
-15
lines changed

flink-runtime-web/web-dashboard/src/app/components/dagre/dagre.component.ts

Lines changed: 0 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -360,7 +360,6 @@ export class DagreComponent extends NzGraph {
360360
* @param $event
361361
*/
362362
onNodeMouseEnter($event: MouseEvent): void {
363-
this.graphElement.nativeElement.appendChild($event.target);
364363
this.layoutLinks.forEach(l => {
365364
if (l.id.split('-').indexOf(($event.target as HTMLElement).id) !== -1) {
366365
l.options.focused = true;
@@ -377,20 +376,6 @@ export class DagreComponent extends NzGraph {
377376
l.options.focused = this.focusedLinkIds.indexOf(l.id) !== -1;
378377
});
379378

380-
this.graphElement.nativeElement.appendChild(this.overlayElement.nativeElement);
381-
382-
this.graphElement.nativeElement.querySelectorAll(`.link-group`).forEach((e: Element) => {
383-
if (this.focusedLinkIds.indexOf(e.id) !== -1) {
384-
this.graphElement.nativeElement.appendChild(e);
385-
}
386-
});
387-
388-
this.graphElement.nativeElement.querySelectorAll(`.node-group`).forEach((e: Element) => {
389-
if ([this.selectedNodeId, ...this.circleNodeIds].indexOf(e.id) !== -1) {
390-
this.graphElement.nativeElement.appendChild(e);
391-
}
392-
});
393-
394379
this.cd.detectChanges();
395380
}
396381

0 commit comments

Comments
 (0)