Skip to content

Commit 267b530

Browse files
committed
[typo] Fix many typos and optimize some code
1 parent dee4735 commit 267b530

File tree

6 files changed

+10
-11
lines changed

6 files changed

+10
-11
lines changed

fluss-server/src/main/java/org/apache/fluss/server/coordinator/CoordinatorEventProcessor.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1005,7 +1005,7 @@ private void processNewTabletServer(NewTabletServerEvent newTabletServerEvent) {
10051005
// it may happen during coordinator server initiation, the watcher watch a new tablet
10061006
// server register event and put it to event manager, but after that, the coordinator
10071007
// server read
1008-
// all tablet server nodes registered which contain the tablet server a; in this case,
1008+
// all tablet server nodes registered which contain the tablet server; in this case,
10091009
// we can ignore it.
10101010
return;
10111011
}
@@ -1398,7 +1398,7 @@ private void tryToCompleteRebalanceTask(TableBucket tableBucket) {
13981398
*
13991399
* <ul>
14001400
* <li>B1. Move all replicas in AR to OnlineReplica state.
1401-
* <li>B2. Send a LeaderAndIsr request with RS = ORS +TRS. The will make the origin leader
1401+
* <li>B2. Send a LeaderAndIsr request with RS = ORS +TRS. This will make the origin leader
14021402
* change to the new leader. this request will be sent to every tabletServer in ORS +TRS.
14031403
* <li>B3. Set RS = TRS, AR = [], RR = [] in memory.
14041404
* <li>Re-send LeaderAndIsr request with new leader and a new RS (using TRS) and same isr to
@@ -1408,7 +1408,7 @@ private void tryToCompleteRebalanceTask(TableBucket tableBucket) {
14081408
* Leader to notify it of the shrunk isr. After that, we send a StopReplica (delete =
14091409
* false and deleteRemote = false) to the replicas in RR.
14101410
* <li>B6. Move all replicas in RR to ReplicaMigrationStarted state. This will send a
1411-
* StopReplica (delete = true and deleteRemote = false) to he replicas in RR to physically
1411+
* StopReplica (delete = true and deleteRemote = false) to the replicas in RR to physically
14121412
* delete the replicas on disk but don't delete the data in remote storage.
14131413
* <li>B7. Update ZK with RS=TRS, AR=[], RR=[].
14141414
* <li>B8. After electing leader, the replicas and isr information changes. So resend the

fluss-server/src/main/java/org/apache/fluss/server/coordinator/CoordinatorRequestBatch.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -276,11 +276,11 @@ public void addStopReplicaRequestForTabletServers(
276276
* none-partitioned table
277277
* <li>case3: Table create and bucketAssignment don't generated, case will happen for new
278278
* created partitioned table
279-
* <li>case4: Table is queued for deletion, in this case we will set a empty tableBucket set
279+
* <li>case4: Table is queued for deletion, in this case we will set an empty tableBucket set
280280
* and tableId set to {@link TableMetadata#DELETED_TABLE_ID} to avoid send unless info to
281281
* tabletServer
282282
* <li>case5: Partition create and bucketAssignment of this partition generated.
283-
* <li>case6: Partition is queued for deletion, in this case we will set a empty tableBucket
283+
* <li>case6: Partition is queued for deletion, in this case we will set an empty tableBucket
284284
* set and partitionId set to {@link PartitionMetadata#DELETED_PARTITION_ID } to avoid
285285
* send unless info to tabletServer
286286
* <li>case7: Leader and isr is changed for these input tableBuckets

fluss-server/src/main/java/org/apache/fluss/server/metrics/group/TableMetricGroup.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,6 @@
3333
import javax.annotation.Nullable;
3434

3535
import java.util.Map;
36-
import java.util.Objects;
3736
import java.util.stream.Stream;
3837

3938
import static org.apache.fluss.metrics.utils.MetricGroupUtils.makeScope;
@@ -267,7 +266,7 @@ public java.util.Collection<BucketMetricGroup> getBucketMetricGroups() {
267266
public Stream<RocksDBStatistics> allRocksDBStatistics() {
268267
return buckets.values().stream()
269268
.map(BucketMetricGroup::getRocksDBStatistics)
270-
.filter(Objects::nonNull);
269+
.filter(stats -> stats != null);
271270
}
272271

273272
public TabletServerMetricGroup getServerMetricGroup() {

website/blog/2025-06-01-partial-updates.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ Next, let's try and better understand how this works in practice with a concrete
4545
### Example: Building a Unified Wide Table
4646
> You can find the full source code on github [here](https://github.com/ververica/ververica-fluss-examples/tree/main/partial_updates).
4747
48-
Start by cloning the repository, run `docker compose up` to spin up the development enviroment and finally grab a terminal
48+
Start by cloning the repository, run `docker compose up` to spin up the development environment and finally grab a terminal
4949
into the `jobmanager` and start the Flink SQL cli, by running the following command:
5050
```shell
5151
./bin/sql-client.sh
@@ -149,7 +149,7 @@ and then run:
149149
```sql
150150
SELECT * FROM user_rec_wide;
151151
```
152-
to observe the output of the table, as we insert `partially` records into the it from the different sources.
152+
to observe the output of the table, as we insert `partially` records into it from the different sources.
153153

154154
**Step 5:** Let's insert the records from the `recommendations` table into the `user_rec_wide` table.
155155
```sql

website/community/how-to-contribute/contribute-code.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ Create an issue and reach consensus.
2828

2929
### Implement
3030

31-
Implement the change according to the Code Style and Quality(refer to the [Flink doc](https://flink.apache.org/how-to-contribute/code-style-and-quality-preamble/) Guide and the approach agreed upon in the issue.
31+
Implement the change according to the Code Style and Quality (refer to the [Flink doc](https://flink.apache.org/how-to-contribute/code-style-and-quality-preamble/) Guide and the approach agreed upon in the issue).
3232

3333
1. Only start working on the implementation if there is consensus on the approach (e.g. you are assigned to the ticket)
3434
2. If you are newer, can refer to [ide setup](/community/dev/ide-setup) to setup a Fluss dev environment.

website/docs/maintenance/filesystems/oss.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ sidebar_position: 3
1212

1313
## Configurations setup
1414

15-
To enabled OSS as remote storage, there are some required configurations that must be add to Fluss' `server.yaml`:
15+
To enabled OSS as remote storage, there are some required configurations that must be added to Fluss' `server.yaml`:
1616

1717
```yaml
1818
# The dir that used to be as the remote storage of Fluss

0 commit comments

Comments
 (0)