Add _validate.tpl tests

Author: morazow

helm/README.md

@@ -51,11 +51,19 @@ For example, for the `security` checks, include and update these methods in the
 
 ```
 {{- define "fluss.validateWarning" -}}
-{{- include "fluss.security.validateWarning" . -}}
+...
+
+{{- $messages = append $messages (include "fluss.security.validateWarning" .) -}}
+
+...
 {{- end -}}
 
 {{- define "fluss.validateError" -}}
-{{- include "fluss.security.validateError" . -}}
+...
+
+{{- $messages = append $messages (include "fluss.security.validateError" .) -}}
+
+...
 {{- end -}}
 ```
 

helm/templates/_validate.tpl

@@ -22,7 +22,12 @@ Usage:
   include "fluss.validateWarning" .
 */}}
 {{- define "fluss.validateWarning" -}}
-{{- include "fluss.security.validateWarning" . -}}
+{{- $messages := list -}}
+
+{{- $messages = append $messages (include "fluss.security.validateWarning" .) -}}
+
+{{- $messages = without $messages "" -}}
+{{- join "\n" $messages -}}
 {{- end -}}
 
 {{/*
@@ -31,7 +36,12 @@ Usage:
   include "fluss.validateError" .
 */}}
 {{- define "fluss.validateError" -}}
-{{- include "fluss.security.validateError" . -}}
+{{- $messages := list -}}
+
+{{- $messages = append $messages (include "fluss.security.validateError" .) -}}
+
+{{- $messages = without $messages "" -}}
+{{- join "\n" $messages -}}
 {{- end -}}
 
 {{/*
@@ -44,13 +54,11 @@ Usage:
 
 {{- $warnMessages := list -}}
 {{- $warnMessages = append $warnMessages (include "fluss.validateWarning" .) -}}
-
 {{- $warnMessages = without $warnMessages "" -}}
 {{- $warnMessage := join "\n" $warnMessages -}}
 
 {{- $errMessages := list -}}
 {{- $errMessages = append $errMessages (include "fluss.validateError" .) -}}
-
 {{- $errMessages = without $errMessages "" -}}
 {{- $errMessage := join "\n" $errMessages -}}
 

helm/tests/validate_test.yaml

@@ -0,0 +1,41 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#      http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+suite: validate-aggregation
+templates:
+  - templates/NOTES.txt
+tests:
+  - it: renders warning for auto-generated internal SASL credentials
+    set:
+      security.internal.sasl.mechanism: plain
+    asserts:
+      - matchRegexRaw:
+          pattern: 'VALUES WARNING:'
+      - matchRegexRaw:
+          pattern: 'AUTO-GENERATED SASL credentials'
+
+  - it: fails with error for invalid mechanism through aggregator
+    set:
+      security.client.sasl.mechanism: bogus
+    asserts:
+      - failedTemplate:
+          errorMessage: "VALUES VALIDATION:\nsecurity.client.sasl.mechanism must be empty or: plain"
+
+  - it: passes cleanly with default values
+    asserts:
+      - notFailedTemplate: {}