Skip to content

Commit 7dd9cc1

Browse files
swuferhongswuferhong
authored
[client] Change the default value of 'client.lookup.max-retries' to Integer.MAX_VALUE (#2096)
1 parent 9c412c9 commit 7dd9cc1

File tree

3 files changed

+19
-21
lines changed

3 files changed

+19
-21
lines changed

‎fluss-common/src/main/java/org/apache/fluss/config/ConfigOptions.java‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1125,7 +1125,7 @@ public class ConfigOptions {
11251125
public static final ConfigOption<Integer> CLIENT_LOOKUP_MAX_RETRIES =
11261126
key("client.lookup.max-retries")
11271127
.intType()
1128-
.defaultValue(3)
1128+
.defaultValue(Integer.MAX_VALUE)
11291129
.withDescription(
11301130
"Setting a value greater than zero will cause the client to resend any lookup request "
11311131
+ "that fails with a potentially transient error.");

‎fluss-flink/fluss-flink-common/src/main/java/org/apache/fluss/flink/catalog/FlinkTableFactory.java‎

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -243,12 +243,10 @@ private static Configuration toFlussClientConfig(
243243
}
244244
});
245245

246-
// map flink lookup.max-retries to client.lookup.max-retries
247-
if (tableOptions.containsKey(LookupOptions.MAX_RETRIES.key())) {
248-
flussConfig.setString(
249-
ConfigOptions.CLIENT_LOOKUP_MAX_RETRIES.key(),
250-
tableOptions.get(LookupOptions.MAX_RETRIES.key()));
251-
}
246+
// Todo support LookupOptions.MAX_RETRIES. Currently, Fluss doesn't support connector level
247+
// retry. The option 'client.lookup.max-retries' is only for dealing with the
248+
// RetriableException return by server not all exceptions. Trace by:
249+
// https://github.com/apache/fluss/issues/2099
252250

253251
// pass flink io tmp dir to fluss client.
254252
flussConfig.setString(

‎website/docs/engine-flink/options.md‎

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -106,20 +106,20 @@ See more details about [ALTER TABLE ... SET](engine-flink/ddl.md#set-properties)
106106

107107
## Lookup Options
108108

109-
| Option | Type | Default | Description |
110-
|------------------------------------------|------------|---------|-----------------------------------------------------------------------------------------------------------------------------|
111-
| lookup.async | Boolean | true | Whether to use asynchronous lookup. Asynchronous lookup has better throughput performance than synchronous lookup. |
112-
| lookup.cache | Enum | NONE | The caching strategy for this lookup table, including NONE, PARTIAL. |
113-
| lookup.max-retries | Integer | 3 | The maximum allowed retries if a lookup operation fails. Setting this value will override option 'client.lookup.max-retries'.|
114-
| lookup.partial-cache.expire-after-access | Duration | (None) | Duration to expire an entry in the cache after accessing. |
115-
| lookup.partial-cache.expire-after-write | Duration | (None) | Duration to expire an entry in the cache after writing. |
116-
| lookup.partial-cache.cache-missing-key | Boolean | true | Whether to store an empty value into the cache if the lookup key doesn't match any rows in the table. |
117-
| lookup.partial-cache.max-rows | Long | (None) | The maximum number of rows to store in the cache. |
118-
| client.lookup.queue-size | Integer | 25600 | The maximum number of pending lookup operations. |
119-
| client.lookup.max-batch-size | Integer | 128 | The maximum batch size of merging lookup operations to one lookup request. |
120-
| client.lookup.max-inflight-requests | Integer | 128 | The maximum number of unacknowledged lookup requests for lookup operations. |
121-
| client.lookup.batch-timeout | Duration | 100ms | The maximum time to wait for the lookup batch to full, if this timeout is reached, the lookup batch will be closed to send. |
122-
| client.lookup.max-retries | Integer | 3 | Setting a value greater than zero will cause the client to resend any lookup request that fails with a potentially transient error. |
109+
| Option | Type | Default | Description |
110+
|------------------------------------------|------------|-------------------|-------------------------------------------------------------------------------------------------------------------------------------|
111+
| lookup.async | Boolean | true | Whether to use asynchronous lookup. Asynchronous lookup has better throughput performance than synchronous lookup. |
112+
| lookup.cache | Enum | NONE | The caching strategy for this lookup table, including NONE, PARTIAL. |
113+
| lookup.max-retries | Integer | 3 | The maximum allowed retries if a lookup operation fails. Setting this value will override option 'client.lookup.max-retries'. |
114+
| lookup.partial-cache.expire-after-access | Duration | (None) | Duration to expire an entry in the cache after accessing. |
115+
| lookup.partial-cache.expire-after-write | Duration | (None) | Duration to expire an entry in the cache after writing. |
116+
| lookup.partial-cache.cache-missing-key | Boolean | true | Whether to store an empty value into the cache if the lookup key doesn't match any rows in the table. |
117+
| lookup.partial-cache.max-rows | Long | (None) | The maximum number of rows to store in the cache. |
118+
| client.lookup.queue-size | Integer | 25600 | The maximum number of pending lookup operations. |
119+
| client.lookup.max-batch-size | Integer | 128 | The maximum batch size of merging lookup operations to one lookup request. |
120+
| client.lookup.max-inflight-requests | Integer | 128 | The maximum number of unacknowledged lookup requests for lookup operations. |
121+
| client.lookup.batch-timeout | Duration | 100ms | The maximum time to wait for the lookup batch to full, if this timeout is reached, the lookup batch will be closed to send. |
122+
| client.lookup.max-retries | Integer | Integer.MAX_VALUE | Setting a value greater than zero will cause the client to resend any lookup request that fails with a potentially transient error. |
123123

124124

125125
## Write Options

0 commit comments

Comments
 (0)