Skip to content

Commit e702012

Browse files
authored
[hotfix] Change commitable to committable to fix typo. (#1318)
1 parent 6e5d732 commit e702012

File tree

9 files changed

+21
-20
lines changed

9 files changed

+21
-20
lines changed

fluss-common/src/main/java/com/alibaba/fluss/lake/committer/LakeCommitter.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ public interface LakeCommitter<WriteResult, CommittableT> extends AutoCloseable
4242
* @return the committable object
4343
* @throws IOException if an I/O error occurs
4444
*/
45-
CommittableT toCommitable(List<WriteResult> writeResults) throws IOException;
45+
CommittableT toCommittable(List<WriteResult> writeResults) throws IOException;
4646

4747
/**
4848
* Commits the given committable object.

fluss-common/src/main/java/com/alibaba/fluss/lake/writer/LakeTieringFactory.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -31,11 +31,11 @@
3131
* serializers for write results and committable objects.
3232
*
3333
* @param <WriteResult> the type of the write result
34-
* @param <CommitableT> the type of the committable object
34+
* @param <CommittableT> the type of the committable object
3535
* @since 0.7
3636
*/
3737
@PublicEvolving
38-
public interface LakeTieringFactory<WriteResult, CommitableT> extends Serializable {
38+
public interface LakeTieringFactory<WriteResult, CommittableT> extends Serializable {
3939

4040
/**
4141
* Creates a lake writer to write Fluss's rows to Paimon/Iceberg rows.
@@ -60,13 +60,13 @@ LakeWriter<WriteResult> createLakeWriter(WriterInitContext writerInitContext)
6060
* @return the lake committer
6161
* @throws IOException if an I/O error occurs
6262
*/
63-
LakeCommitter<WriteResult, CommitableT> createLakeCommitter(
63+
LakeCommitter<WriteResult, CommittableT> createLakeCommitter(
6464
CommitterInitContext committerInitContext) throws IOException;
6565

6666
/**
6767
* Returns the serializer for committable objects.
6868
*
6969
* @return the serializer for committable objects
7070
*/
71-
SimpleVersionedSerializer<CommitableT> getCommitableSerializer();
71+
SimpleVersionedSerializer<CommittableT> getCommittableSerializer();
7272
}

fluss-flink/fluss-flink-common/src/main/java/com/alibaba/fluss/flink/tiering/LakeTieringJobBuilder.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,7 @@ public JobClient build() throws Exception {
9898
source.transform(
9999
"TieringCommitter",
100100
CommittableMessageTypeInfo.of(
101-
() -> lakeTieringFactory.getCommitableSerializer()),
101+
() -> lakeTieringFactory.getCommittableSerializer()),
102102
new TieringCommitOperatorFactory(flussConfig, lakeTieringFactory))
103103
.setParallelism(1)
104104
.setMaxParallelism(1)

fluss-flink/fluss-flink-common/src/main/java/com/alibaba/fluss/flink/tiering/committer/TieringCommitOperator.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@
6464
*
6565
* <p>When it collects all {@link TableBucketWriteResult}s of a round of tiering for a table, it
6666
* will combine all the {@link WriteResult}s to {@link Committable} via method {@link
67-
* LakeCommitter#toCommitable(List)}, and then call method {@link LakeCommitter#commit(Object)} to
67+
* LakeCommitter#toCommittable(List)}, and then call method {@link LakeCommitter#commit(Object)} to
6868
* commit to lake.
6969
*
7070
* <p>Finally, it will also commit the commited lake snapshot to Fluss cluster to make Fluss aware
@@ -180,7 +180,7 @@ private Committable commitWriteResults(
180180
.map(TableBucketWriteResult::writeResult)
181181
.collect(Collectors.toList());
182182
// to committable
183-
Committable committable = lakeCommitter.toCommitable(writeResults);
183+
Committable committable = lakeCommitter.toCommittable(writeResults);
184184
// before commit to lake, check fluss not missing any lake snapshot commited by fluss
185185
checkFlussNotMissingLakeSnapshot(tablePath, lakeCommitter, committable);
186186
long commitedSnapshotId = lakeCommitter.commit(committable);

fluss-flink/fluss-flink-common/src/test/java/com/alibaba/fluss/flink/tiering/TestingLakeTieringFactory.java

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -66,8 +66,9 @@ public LakeCommitter<TestingWriteResult, TestingCommittable> createLakeCommitter
6666
}
6767

6868
@Override
69-
public SimpleVersionedSerializer<TestingCommittable> getCommitableSerializer() {
70-
throw new UnsupportedOperationException("method getCommitableSerializer is not supported.");
69+
public SimpleVersionedSerializer<TestingCommittable> getCommittableSerializer() {
70+
throw new UnsupportedOperationException(
71+
"method getCommittableSerializer is not supported.");
7172
}
7273

7374
private static final class TestingLakeWriter implements LakeWriter<TestingWriteResult> {
@@ -107,7 +108,7 @@ public TestingLakeCommitter(@Nullable CommittedLakeSnapshot mockCommittedSnapsho
107108
}
108109

109110
@Override
110-
public TestingCommittable toCommitable(List<TestingWriteResult> testingWriteResults)
111+
public TestingCommittable toCommittable(List<TestingWriteResult> testingWriteResults)
111112
throws IOException {
112113
List<Integer> writeResults = new ArrayList<>();
113114
for (TestingWriteResult testingWriteResult : testingWriteResults) {

fluss-lake/fluss-lake-paimon/src/main/java/com/alibaba/fluss/lake/paimon/tiering/PaimonLakeCommitter.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ public PaimonLakeCommitter(PaimonCatalogProvider paimonCatalogProvider, TablePat
6565
}
6666

6767
@Override
68-
public PaimonCommittable toCommitable(List<PaimonWriteResult> paimonWriteResults)
68+
public PaimonCommittable toCommittable(List<PaimonWriteResult> paimonWriteResults)
6969
throws IOException {
7070
ManifestCommittable committable = new ManifestCommittable(COMMIT_IDENTIFIER);
7171
for (PaimonWriteResult paimonWriteResult : paimonWriteResults) {

fluss-lake/fluss-lake-paimon/src/main/java/com/alibaba/fluss/lake/paimon/tiering/PaimonLakeTieringFactory.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ public LakeCommitter<PaimonWriteResult, PaimonCommittable> createLakeCommitter(
5959
}
6060

6161
@Override
62-
public SimpleVersionedSerializer<PaimonCommittable> getCommitableSerializer() {
62+
public SimpleVersionedSerializer<PaimonCommittable> getCommittableSerializer() {
6363
return new PaimonCommittableSerializer();
6464
}
6565
}

fluss-lake/fluss-lake-paimon/src/test/java/com/alibaba/fluss/lake/paimon/tiering/PaimonTieringTest.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -120,7 +120,7 @@ void testTieringWriteTable(boolean isPrimaryKeyTable, boolean isPartitioned) thr
120120
SimpleVersionedSerializer<PaimonWriteResult> writeResultSerializer =
121121
paimonLakeTieringFactory.getWriteResultSerializer();
122122
SimpleVersionedSerializer<PaimonCommittable> committableSerializer =
123-
paimonLakeTieringFactory.getCommitableSerializer();
123+
paimonLakeTieringFactory.getCommittableSerializer();
124124

125125
try (LakeCommitter<PaimonWriteResult, PaimonCommittable> lakeCommitter =
126126
createLakeCommitter(tablePath)) {
@@ -161,7 +161,7 @@ void testTieringWriteTable(boolean isPrimaryKeyTable, boolean isPartitioned) thr
161161
try (LakeCommitter<PaimonWriteResult, PaimonCommittable> lakeCommitter =
162162
createLakeCommitter(tablePath)) {
163163
// serialize/deserialize committable
164-
PaimonCommittable paimonCommittable = lakeCommitter.toCommitable(paimonWriteResults);
164+
PaimonCommittable paimonCommittable = lakeCommitter.toCommittable(paimonWriteResults);
165165
byte[] serialized = committableSerializer.serialize(paimonCommittable);
166166
paimonCommittable =
167167
committableSerializer.deserialize(
@@ -246,7 +246,7 @@ void testMultiPartitionTiering() throws Exception {
246246
// Commit all data
247247
try (LakeCommitter<PaimonWriteResult, PaimonCommittable> lakeCommitter =
248248
createLakeCommitter(tablePath)) {
249-
PaimonCommittable committable = lakeCommitter.toCommitable(paimonWriteResults);
249+
PaimonCommittable committable = lakeCommitter.toCommittable(paimonWriteResults);
250250
long snapshot = lakeCommitter.commit(committable);
251251
assertThat(snapshot).isEqualTo(1);
252252
}
@@ -295,7 +295,7 @@ void testThreePartitionTiering() throws Exception {
295295
// Commit all data
296296
try (LakeCommitter<PaimonWriteResult, PaimonCommittable> lakeCommitter =
297297
createLakeCommitter(tablePath)) {
298-
PaimonCommittable committable = lakeCommitter.toCommitable(paimonWriteResults);
298+
PaimonCommittable committable = lakeCommitter.toCommittable(paimonWriteResults);
299299
long snapshot = lakeCommitter.commit(committable);
300300
assertThat(snapshot).isEqualTo(1);
301301
}

website/blog/2025-07-01-tiering-service.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -166,16 +166,16 @@ public interface LakeTieringFactory {
166166

167167
SimpleVersionedSerializer<WriteResult> getWriteResultSerializer();
168168

169-
LakeCommitter<WriteResult, CommitableT> createLakeCommitter(
169+
LakeCommitter<WriteResult, CommittableT> createLakeCommitter(
170170
CommitterInitContext committerInitContext);
171171

172-
SimpleVersionedSerializer<CommitableT> getCommitableSerializer();
172+
SimpleVersionedSerializer<CommittableT> getCommittableSerializer();
173173
}
174174
```
175175
- **createLakeWriter(WriterInitContext)**: builds a `LakeWriter` to convert Fluss rows into the target table format.
176176
- **getWriteResultSerializer()**: supplies a serializer for the writer’s output.
177177
- **createLakeCommitter(CommitterInitContext)**: constructs a `LakeCommitter` to finalize and atomically commit data files.
178-
- **getCommitableSerializer()**: provides a serializer for committable tokens.```
178+
- **getCommittableSerializer()**: provides a serializer for committable tokens.```
179179

180180
By default, Fluss includes a Paimon-backed tiering factory; Iceberg support is coming soon. Once the `TieringSourceReader` writes a batch of records through the `LakeWriter`, it emits the resulting write metadata downstream to the **TieringCommitOperator**, which then commits those changes both in the lakehouse and back to the Fluss cluster.
181181

0 commit comments

Comments
 (0)